You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/02/08 10:42:23 UTC

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9659: [3.0] ServiceDefinition usage refactor & distinguish serviceName and interfaceName

codecov-commenter edited a comment on pull request #9659:
URL: https://github.com/apache/dubbo/pull/9659#issuecomment-1032460893


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9659?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9659](https://codecov.io/gh/apache/dubbo/pull/9659?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (09bf9fc) into [3.0](https://codecov.io/gh/apache/dubbo/commit/1bf7396fb74b7a920b0ff75089c6498f3fddd14f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1bf7396) will **decrease** coverage by `0.02%`.
   > The diff coverage is `74.46%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9659/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9659?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9659      +/-   ##
   ============================================
   - Coverage     65.67%   65.65%   -0.03%     
   - Complexity      296      297       +1     
   ============================================
     Files          1191     1192       +1     
     Lines         52115    52147      +32     
     Branches       7917     7916       -1     
   ============================================
   + Hits          34228    34238      +10     
   - Misses        14195    14219      +24     
   + Partials       3692     3690       -2     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9659?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [.../cluster/filter/support/ConsumerContextFilter.java](https://codecov.io/gh/apache/dubbo/pull/9659/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvZmlsdGVyL3N1cHBvcnQvQ29uc3VtZXJDb250ZXh0RmlsdGVyLmphdmE=) | `64.10% <0.00%> (ø)` | |
   | [...rc/main/java/com/alibaba/dubbo/rpc/Invocation.java](https://codecov.io/gh/apache/dubbo/pull/9659/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tcGF0aWJsZS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9JbnZvY2F0aW9uLmphdmE=) | `9.52% <0.00%> (-0.24%)` | :arrow_down: |
   | [...nt/migration/ServiceDiscoveryMigrationInvoker.java](https://codecov.io/gh/apache/dubbo/pull/9659/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvbWlncmF0aW9uL1NlcnZpY2VEaXNjb3ZlcnlNaWdyYXRpb25JbnZva2VyLmphdmE=) | `18.75% <0.00%> (ø)` | |
   | [...src/main/java/org/apache/dubbo/rpc/Invocation.java](https://codecov.io/gh/apache/dubbo/pull/9659/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9JbnZvY2F0aW9uLmphdmE=) | `20.00% <ø> (ø)` | |
   | [...e/dubbo/rpc/protocol/tri/AbstractServerStream.java](https://codecov.io/gh/apache/dubbo/pull/9659/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy10cmlwbGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm90b2NvbC90cmkvQWJzdHJhY3RTZXJ2ZXJTdHJlYW0uamF2YQ==) | `50.00% <33.33%> (ø)` | |
   | [.../apache/dubbo/rpc/protocol/injvm/InjvmInvoker.java](https://codecov.io/gh/apache/dubbo/pull/9659/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1pbmp2bS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL3Byb3RvY29sL2luanZtL0luanZtSW52b2tlci5qYXZh) | `72.44% <50.00%> (ø)` | |
   | [.../org/apache/dubbo/rpc/model/ServiceDescriptor.java](https://codecov.io/gh/apache/dubbo/pull/9659/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9ycGMvbW9kZWwvU2VydmljZURlc2NyaXB0b3IuamF2YQ==) | `79.16% <71.42%> (+0.32%)` | :arrow_up: |
   | [.../dubbo/registry/client/metadata/MetadataUtils.java](https://codecov.io/gh/apache/dubbo/pull/9659/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktYXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9yZWdpc3RyeS9jbGllbnQvbWV0YWRhdGEvTWV0YWRhdGFVdGlscy5qYXZh) | `75.58% <80.00%> (+2.32%)` | :arrow_up: |
   | [.../main/java/org/apache/dubbo/rpc/RpcInvocation.java](https://codecov.io/gh/apache/dubbo/pull/9659/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNJbnZvY2F0aW9uLmphdmE=) | `69.26% <82.35%> (ø)` | |
   | [.../rpc/cluster/router/mesh/route/MeshRuleRouter.java](https://codecov.io/gh/apache/dubbo/pull/9659/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvcm91dGVyL21lc2gvcm91dGUvTWVzaFJ1bGVSb3V0ZXIuamF2YQ==) | `94.26% <100.00%> (ø)` | |
   | ... and [23 more](https://codecov.io/gh/apache/dubbo/pull/9659/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9659?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9659?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [1bf7396...09bf9fc](https://codecov.io/gh/apache/dubbo/pull/9659?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org