You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/08/16 19:49:59 UTC

[GitHub] [arrow] nealrichardson commented on a change in pull request #10457: ARROW-12980: [C++] Kernels to extract datetime components should be timezone aware

nealrichardson commented on a change in pull request #10457:
URL: https://github.com/apache/arrow/pull/10457#discussion_r689812738



##########
File path: r/tests/testthat/test-dplyr-lubridate.R
##########
@@ -26,22 +26,13 @@ library(dplyr)
 # TODO: consider reevaluating this workaround after ARROW-12980
 withr::local_timezone("UTC")
 
-test_date <- as.POSIXct("2017-01-01 00:00:12.3456789", tz = "")
+if (tolower(Sys.info()[["sysname"]]) == "windows") {

Review comment:
       Why is windows special-cased here? This needs an explanatory comment and possibly a link to a jira that will let us delete this.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org