You are viewing a plain text version of this content. The canonical link for it is here.
Posted to codereview@trafodion.apache.org by Weixin-Xu <gi...@git.apache.org> on 2018/09/26 07:21:14 UTC
[GitHub] trafodion pull request #1718: ODBC error message is truncated
GitHub user Weixin-Xu opened a pull request:
https://github.com/apache/trafodion/pull/1718
ODBC error message is truncated
I found that user pass the length with char then Windows DriverManager will pass the length/2 to driver.
So it is not necessary here to divide the length by two.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Weixin-Xu/incubator-trafodion J3214
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/trafodion/pull/1718.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1718
----
commit 1e237e9273f9be15e28fae0b6cf079a1b64c31c3
Author: Weixin-Xu <10...@...>
Date: 2018-09-26T07:17:53Z
the error message is truncated
----
---
[GitHub] trafodion pull request #1718: [TRAFODION-3214] ODBC error message is truncat...
Posted by Weixin-Xu <gi...@git.apache.org>.
Github user Weixin-Xu commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1718#discussion_r220773369
--- Diff: win-odbc64/odbcclient/drvr35/cdiag.cpp ---
@@ -378,15 +378,15 @@ SQLRETURN CDiagRec::GetDiagRec(SQLSMALLINT RecNumber,
//Double strLen to circumvent the bug in driver manager, that requires us to give
//the NO. OF BYTES instead of no. of characters
- strLen = tmpStrLen * 2;
+ strLen = tmpStrLen;
--- End diff --
Yes, it seems the bug mentioned is fixed and I will verify it.
---
[GitHub] trafodion pull request #1718: [TRAFODION-3214] ODBC error message is truncat...
Posted by DaveBirdsall <gi...@git.apache.org>.
Github user DaveBirdsall commented on a diff in the pull request:
https://github.com/apache/trafodion/pull/1718#discussion_r220703185
--- Diff: win-odbc64/odbcclient/drvr35/cdiag.cpp ---
@@ -378,15 +378,15 @@ SQLRETURN CDiagRec::GetDiagRec(SQLSMALLINT RecNumber,
//Double strLen to circumvent the bug in driver manager, that requires us to give
//the NO. OF BYTES instead of no. of characters
- strLen = tmpStrLen * 2;
+ strLen = tmpStrLen;
--- End diff --
Should the comment before this statement be deleted?
---