[jira] [Comment Edited] (OOZIE-2940) Possible NullPointerException

["Andras Piros (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OOZIE-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16125554#comment-16125554 ] 

Andras Piros edited comment on OOZIE-2940 at 8/14/17 11:24 AM:
---------------------------------------------------------------

LGTM +1 (non-binding). Can you please upload the patch here?


was (Author: andras.piros):
LGTM +1 (non-binding). [~asasvari] can you pls. review?

> Possible NullPointerException
> -----------------------------
>
>                 Key: OOZIE-2940
>                 URL: https://issues.apache.org/jira/browse/OOZIE-2940
>             Project: Oozie
>          Issue Type: Bug
>          Components: workflow
>    Affects Versions: 4.3.0
>            Reporter: AppChecker
>            Assignee: Denes Bodo
>              Labels: appchecker, static-analysis
>
> Hi.
> In [this code|https://github.com/apache/oozie/blob/eb168360c550943828d9fe2c7bfdcd4f5e830003/core/src/main/java/org/apache/oozie/WorkflowActionBean.java#L600]:
> {code:java}
>         if (status == null || (status != Status.OK && status != Status.ERROR && status != Status.KILLED)) {
>             throw new IllegalArgumentException("Action status must be OK, ERROR or KILLED. Received ["
>                     + status.toString() + "]");
>         }
> {code}
> if status is null, status.toString() will be executed, so NullPointerException will be throw.
> This possible defect found by [AppChecker|https://npo-echelon.ru/en/solutions/appchecker.php].



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)