You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/09/27 22:13:38 UTC

[GitHub] anirudh2290 commented on a change in pull request #12687: ignore a 3rd party libray in cpplint

anirudh2290 commented on a change in pull request #12687: ignore a 3rd party libray in cpplint
URL: https://github.com/apache/incubator-mxnet/pull/12687#discussion_r221093683
 
 

 ##########
 File path: Makefile
 ##########
 @@ -568,7 +568,7 @@ lint: cpplint rcpplint jnilint pylint
 
 cpplint:
 	3rdparty/dmlc-core/scripts/lint.py mxnet cpp include src plugin cpp-package tests \
-	--exclude_path src/operator/contrib/ctc_include
+	--exclude_path src/operator/contrib/ctc_include src/operator/nn/ctc_include
 
 Review comment:
   Hi @apeforest, I think if we are adding it to src/operator/nn we should enforce the same lint checks enforced on rest of the code of MXNet. We can create exception for contrib but not very comfortable adding exception for src/operator/nn dir. I would like to hear other opinions.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services