[GitHub] [httpcomponents-core] rhernandez35 commented on issue #146: Set accessiblity flag on reflected methods in ReflectionUtils

[GitBox <gi...@apache.org>]

rhernandez35 commented on issue #146: Set accessiblity flag on reflected methods in ReflectionUtils
URL: https://github.com/apache/httpcomponents-core/pull/146#issuecomment-528279732
 
 
   > is there a chance you could minimize stylistic changes to the existing classes?
   
   Yeah, definitely. I hit everything with a round of vim auto-indent for speed after copy-pasting some stuff around, but I'll go back and do the formatting manually so it's consistent.
   
   > Is there is a particular problem with using JUnit rules?
   
   For test setup? No. the switch to just using `@Before` is an artifact from an earlier attempt at writing tests.
   
   I'm not a fan of using rules for validating thrown exceptions. I think it's much safer to explicitly check for them where I expect them to be thrown in code. Otherwise, it's easy to accidentally skip assertions if a call unexpectedly throws the exception we're looking for.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org