You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "Efrat19 (via GitHub)" <gi...@apache.org> on 2025/04/21 06:28:15 UTC

[PR] [FLINK-37705] JobPlanInfo properties spec adjustments [flink]

Efrat19 opened a new pull request, #26488:
URL: https://github.com/apache/flink/pull/26488

   ## What is the purpose of the change
   Addressing nits from https://github.com/apache/flink/pull/26320
   1. https://github.com/apache/flink/pull/26320/files#r2051997572 Return `optimizerProps` as `rawJson`
   2. https://github.com/apache/flink/pull/26320#discussion_r2032884834 Hide null fields
   
   ## Verifying this change
   
   <details>
   <summary>Example plan response</summary>
   
   ```json
   {
       "plan": {
           "jid": "3da5f3665a4c6430f55f5ca38f677270",
           "name": "Windowed Join Example",
           "type": "STREAMING",
           "nodes": [
               {
                   "id": "8b481b930a189b6b1762a9d95a61ada1",
                   "operator": "",
                   "parallelism": 1,
                   "operator_strategy": "",
                   "description": "Window(TumblingEventTimeWindows(2000), EventTimeTrigger, CoGroupWindowFunction)<br/>+- Sink: Print to Std. Out<br/>",
                   "optimizer_properties": {},
                   "inputs": [
                       {
                           "id": "cbc357ccb763df2852fee8c4fc7d55f2",
                           "num": 0,
                           "exchange": "pipelined_bounded",
                           "ship_strategy": "HASH"
                       },
                       {
                           "id": "6cdc5bb954874d922eaee11a8e7b5dd5",
                           "num": 1,
                           "exchange": "pipelined_bounded",
                           "ship_strategy": "HASH"
                       }
                   ]
               },
               {
                   "id": "cbc357ccb763df2852fee8c4fc7d55f2",
                   "operator": "",
                   "parallelism": 1,
                   "operator_strategy": "",
                   "description": "Source: Grades Data Generator<br/>+- Map<br/>",
                   "optimizer_properties": {}
               },
               {
                   "id": "6cdc5bb954874d922eaee11a8e7b5dd5",
                   "operator": "",
                   "parallelism": 1,
                   "operator_strategy": "",
                   "description": "Source: Grades Data Generator<br/>+- Map<br/>",
                   "optimizer_properties": {}
               }
           ]
       }
   }
   ```
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-37705][rest] JobPlanInfo properties spec adjustments [flink]

Posted by "rkhachatryan (via GitHub)" <gi...@apache.org>.
rkhachatryan commented on code in PR #26488:
URL: https://github.com/apache/flink/pull/26488#discussion_r2057863990


##########
flink-runtime-web/src/test/resources/rest_api_v1.snapshot:
##########
@@ -366,7 +366,8 @@
                     "type" : "string"
                   },
                   "optimizer_properties" : {
-                    "type" : "string"
+                    "type" : "object",
+                    "id" : "urn:jsonschema:org:apache:flink:runtime:rest:messages:JobPlanInfo:RawJson"

Review Comment:
   I don't understand where does this `id` come from, could you explain?
   It should be something like
   `optimizer_properties : global_properties { ... }`
   
   But with this change, it would be
   `optimizer_properties : id { global_properties { ... } }`
   
   Wouldn't it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-37705][rest] JobPlanInfo properties spec adjustments [flink]

Posted by "Efrat19 (via GitHub)" <gi...@apache.org>.
Efrat19 commented on PR #26488:
URL: https://github.com/apache/flink/pull/26488#issuecomment-2818475344

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-37705] JobPlanInfo properties spec adjustments [flink]

Posted by "Efrat19 (via GitHub)" <gi...@apache.org>.
Efrat19 commented on PR #26488:
URL: https://github.com/apache/flink/pull/26488#issuecomment-2817914260

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-37705][rest] JobPlanInfo properties spec adjustments [flink]

Posted by "Efrat19 (via GitHub)" <gi...@apache.org>.
Efrat19 commented on code in PR #26488:
URL: https://github.com/apache/flink/pull/26488#discussion_r2058014064


##########
flink-runtime-web/src/test/resources/rest_api_v1.snapshot:
##########
@@ -366,7 +366,8 @@
                     "type" : "string"
                   },
                   "optimizer_properties" : {
-                    "type" : "string"
+                    "type" : "object",
+                    "id" : "urn:jsonschema:org:apache:flink:runtime:rest:messages:JobPlanInfo:RawJson"

Review Comment:
   I don't think so. `id` isn't a property of `optimizer_properties` but rather contains the schema path (since its an object now)
   Objects have either `id` or a `$ref` to their schema (not sure when is each used)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-37705][rest] JobPlanInfo properties spec adjustments [flink]

Posted by "Efrat19 (via GitHub)" <gi...@apache.org>.
Efrat19 commented on PR #26488:
URL: https://github.com/apache/flink/pull/26488#issuecomment-2820209268

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-37705][rest] JobPlanInfo properties spec adjustments [flink]

Posted by "rkhachatryan (via GitHub)" <gi...@apache.org>.
rkhachatryan commented on code in PR #26488:
URL: https://github.com/apache/flink/pull/26488#discussion_r2058201743


##########
flink-runtime-web/src/test/resources/rest_api_v1.snapshot:
##########
@@ -366,7 +366,8 @@
                     "type" : "string"
                   },
                   "optimizer_properties" : {
-                    "type" : "string"
+                    "type" : "object",
+                    "id" : "urn:jsonschema:org:apache:flink:runtime:rest:messages:JobPlanInfo:RawJson"

Review Comment:
   Thanks for clarifying!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-37705][rest] JobPlanInfo properties spec adjustments [flink]

Posted by "rkhachatryan (via GitHub)" <gi...@apache.org>.
rkhachatryan commented on code in PR #26488:
URL: https://github.com/apache/flink/pull/26488#discussion_r2057863990


##########
flink-runtime-web/src/test/resources/rest_api_v1.snapshot:
##########
@@ -366,7 +366,8 @@
                     "type" : "string"
                   },
                   "optimizer_properties" : {
-                    "type" : "string"
+                    "type" : "object",
+                    "id" : "urn:jsonschema:org:apache:flink:runtime:rest:messages:JobPlanInfo:RawJson"

Review Comment:
   I don't understand where does this `id` come from, could you explain?
   It should be something like this (according to the current code `JsonMapper.getOptimizerPropertiesJson` IIUC):
   `optimizer_properties : global_properties { ... }`
   
   But with this change, it would be
   `optimizer_properties : id { global_properties { ... } }`
   
   Wouldn't it?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-37705] JobPlanInfo properties spec adjustments [flink]

Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #26488:
URL: https://github.com/apache/flink/pull/26488#issuecomment-2817750153

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "a642b2f98cbb0b5a19ebb24f3e8bc749b79c8d97",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "a642b2f98cbb0b5a19ebb24f3e8bc749b79c8d97",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * a642b2f98cbb0b5a19ebb24f3e8bc749b79c8d97 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-37705][rest] JobPlanInfo properties spec adjustments [flink]

Posted by "Efrat19 (via GitHub)" <gi...@apache.org>.
Efrat19 commented on PR #26488:
URL: https://github.com/apache/flink/pull/26488#issuecomment-2818239895

   
   @flinkbot run azure
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] [FLINK-37705][rest] JobPlanInfo properties spec adjustments [flink]

Posted by "rkhachatryan (via GitHub)" <gi...@apache.org>.
rkhachatryan merged PR #26488:
URL: https://github.com/apache/flink/pull/26488


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org