You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by witgo <gi...@git.apache.org> on 2016/09/06 14:37:12 UTC

[GitHub] spark pull request #14977: [Test Only][not ready for review][SPARK-6235][COR...

GitHub user witgo opened a pull request:

    https://github.com/apache/spark/pull/14977

    [Test Only][not ready for review][SPARK-6235][CORE]Address various 2G limits

    ## What changes were proposed in this pull request?
    
    ### Design
    
    #### Setup for eliminating the various 2G limit in Spark. 
    
    ##### Replace ByteBuffer with ChunkedByteBuffer.
    
    1. Move the ChunkedByteBuffer class to `common/network-common/src/main/java/org/apache/spark/network/buffer/`
    2. Modify `ManagedBuffer.nioByteBuffer`'s return value to ChunkedByteBuffer instance.
    3. Modify the parameter of `SerializerInstance.deserialize` and the return value of `SerializerInstance.serialize` ChunkedByteBuffer instance.
    4. Other changes.
    
    ##### Replace ByteBuf with InputStream. 
    
    1. Add InputStreamManagedBuffer class, used to convert InputStream instance to ManagedBuffer instance.
    2. Modify `NioManagedBuffer.convertToNetty` method returns InputStream instances when data is larger than Integer.MAX_VALUE. 
    3. Modify the parameters of the `Encodable.encode` method to OutputStream instance. 
    4. Modify the parameters of the decode method of the classes who implement the Encodable interface to InputStream instance.
    5. Modify TransportFrameDecoder class, use `LinkedList<ByteBuf>` to represent the Frame, remove the size limit of Frame.
    6. Add ByteBufInputStream class, used to convert `LinkedList<ByteBuf>` instance to InputStream instance.  
    7. Modify the parameters of `RpcHandler.receive` method to InputStream instance.
    
    ## How was this patch tested?
    
    TODO ...
    
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/witgo/spark SPARK-17082_SPARK-17184_ChunkedByteBuffer_InputStream

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/14977.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #14977
    
----
commit 5259ecf99d3d569ed07b9caa2434483729ffd327
Author: Guoqiang Li <wi...@qq.com>
Date:   2016-09-06T14:28:01Z

    Address various 2G limits

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14977: [Test Only][not ready for review][SPARK-6235][CORE]Addre...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/14977
  
    **[Test build #64999 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64999/consoleFull)** for PR 14977 at commit [`5259ecf`](https://github.com/apache/spark/commit/5259ecf99d3d569ed07b9caa2434483729ffd327).
     * This patch **fails MiMa tests**.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14977: [Test Only][not ready for review][SPARK-6235][CORE]Addre...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/14977
  
    Test FAILed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64999/
    Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14977: [Test Only][not ready for review][SPARK-6235][CORE]Addre...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/14977
  
    Merged build finished. Test FAILed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14977: [Test Only][not ready for review][SPARK-6235][CORE]Addre...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/14977
  
    **[Test build #64999 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64999/consoleFull)** for PR 14977 at commit [`5259ecf`](https://github.com/apache/spark/commit/5259ecf99d3d569ed07b9caa2434483729ffd327).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request #14977: [Test Only][not ready for review][SPARK-6235][COR...

Posted by witgo <gi...@git.apache.org>.
Github user witgo closed the pull request at:

    https://github.com/apache/spark/pull/14977


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org