You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/11/10 00:00:15 UTC
[GitHub] [yunikorn-k8shim] craigcondit opened a new pull request, #477: [YUNIKORN-1391] Use consistent locking in shim node cache
craigcondit opened a new pull request, #477:
URL: https://github.com/apache/yunikorn-k8shim/pull/477
### What is this PR for?
Updates locking in shim's node cache to ensure consistent reads and writes of mutable state.
### What type of PR is it?
* [x] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/YUNIKORN-1391
### How should this be tested?
Tests updated to use new methods.
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #477: [YUNIKORN-1391] Use consistent locking in shim node cache
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #477:
URL: https://github.com/apache/yunikorn-k8shim/pull/477#issuecomment-1309569032
# [Codecov](https://codecov.io/gh/apache/yunikorn-k8shim/pull/477?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#477](https://codecov.io/gh/apache/yunikorn-k8shim/pull/477?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c36854b) into [master](https://codecov.io/gh/apache/yunikorn-k8shim/commit/8ff45c33edd7e592d8c752f3eb366c233b66e1b5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (8ff45c3) will **increase** coverage by `0.04%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #477 +/- ##
==========================================
+ Coverage 68.03% 68.08% +0.04%
==========================================
Files 42 42
Lines 6921 6925 +4
==========================================
+ Hits 4709 4715 +6
+ Misses 2042 2040 -2
Partials 170 170
```
| [Impacted Files](https://codecov.io/gh/apache/yunikorn-k8shim/pull/477?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [pkg/cache/node.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/477/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL25vZGUuZ28=) | `86.77% <100.00%> (+2.03%)` | :arrow_up: |
| [pkg/cache/nodes.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/477/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL25vZGVzLmdv) | `79.72% <100.00%> (+0.13%)` | :arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [yunikorn-k8shim] wilfred-s closed pull request #477: [YUNIKORN-1391] Use consistent locking in shim node cache
Posted by GitBox <gi...@apache.org>.
wilfred-s closed pull request #477: [YUNIKORN-1391] Use consistent locking in shim node cache
URL: https://github.com/apache/yunikorn-k8shim/pull/477
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org