You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2022/01/19 07:01:55 UTC
[GitHub] [incubator-brpc] EricccYang opened a new pull request #1678: compatible with protobuf after v3.18.0(include)
EricccYang opened a new pull request #1678:
URL: https://github.com/apache/incubator-brpc/pull/1678
a function "SetTotalBytesLimit" has been changed since protobuf v3.18.0.
Related issue in google protobuf :
https://github.com/protocolbuffers/protobuf/pull/8794
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] EricccYang commented on pull request #1678: compatible with protobuf after v3.18.0(include)
Posted by GitBox <gi...@apache.org>.
EricccYang commented on pull request #1678:
URL: https://github.com/apache/incubator-brpc/pull/1678#issuecomment-1018154955
Got it. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] lorinlee commented on pull request #1678: compatible with protobuf after v3.18.0(include)
Posted by GitBox <gi...@apache.org>.
lorinlee commented on pull request #1678:
URL: https://github.com/apache/incubator-brpc/pull/1678#issuecomment-1018129260
Hi @EricccYang , Thank you so much for your contribution! To make the commits log clear, could you squash four commits into one commit?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] lorinlee commented on pull request #1678: compatible with protobuf after v3.18.0(include)
Posted by GitBox <gi...@apache.org>.
lorinlee commented on pull request #1678:
URL: https://github.com/apache/incubator-brpc/pull/1678#issuecomment-1018134922
Hi @EricccYang , This PR's content is covered by #1679. #1679 comes from #1657 , which has been pushed before 23 days ago, so I will merge #1679 , Thank you for your contribution again!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org
[GitHub] [incubator-brpc] EricccYang closed pull request #1678: compatible with protobuf after v3.18.0(include)
Posted by GitBox <gi...@apache.org>.
EricccYang closed pull request #1678:
URL: https://github.com/apache/incubator-brpc/pull/1678
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org