You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jon Meredith (Jira)" <ji...@apache.org> on 2022/01/11 00:17:00 UTC

[jira] [Updated] (CASSANDRA-17252) ConnectionLimitHandler may leaks connection count if remote connection drops

     [ https://issues.apache.org/jira/browse/CASSANDRA-17252?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jon Meredith updated CASSANDRA-17252:
-------------------------------------
     Bug Category: Parent values: Degradation(12984)Level 1 values: Resource Management(12995)
       Complexity: Normal
      Component/s: Messaging/Client
    Discovered By: User Report
    Fix Version/s: 3.0.x
                   3.11.x
                   4.0.x
                   4.x
         Severity: Low
         Assignee: Jon Meredith
           Status: Open  (was: Triage Needed)

Looks like the issue was present since

initial commit in CASSANDRA-8086 / e56d9efb7c1 , but perhaps Netty behaved differently pre-tcnative.

> ConnectionLimitHandler may leaks connection count if remote connection drops
> ----------------------------------------------------------------------------
>
>                 Key: CASSANDRA-17252
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17252
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Messaging/Client
>            Reporter: Jon Meredith
>            Assignee: Jon Meredith
>            Priority: Normal
>             Fix For: 3.0.x, 3.11.x, 4.0.x, 4.x
>
>
> In some cases, Netty does not return the original IP used for per-IP counting when the channel becomes inactive,
> which throws an NPE before decrementing the active per-IP count.
> {code:java}
> java.lang.NullPointerException
> at org.apache.cassandra.transport.ConnectionLimitHandler.channelInactive(ConnectionLimitHandler.java:101)
>        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:262)
>        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:248)
>        at io.netty.channel.AbstractChannelHandlerContext.fireChannelInactive(AbstractChannelHandlerContext.java:241)
>        at io.netty.handler.codec.ByteToMessageDecoder.channelInputClosed(ByteToMessageDecoder.java:389)
>        at io.netty.handler.codec.ByteToMessageDecoder.channelInactive(ByteToMessageDecoder.java:354)
>        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:262)
>        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:248)
>        at io.netty.channel.AbstractChannelHandlerContext.fireChannelInactive(AbstractChannelHandlerContext.java:241)
>        at io.netty.channel.DefaultChannelPipeline$HeadContext.channelInactive(DefaultChannelPipeline.java:1405)
>        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:262)
>        at io.netty.channel.AbstractChannelHandlerContext.invokeChannelInactive(AbstractChannelHandlerContext.java:248)
>        at io.netty.channel.DefaultChannelPipeline.fireChannelInactive(DefaultChannelPipeline.java:901)
>        at io.netty.channel.AbstractChannel$AbstractUnsafe$8.run(AbstractChannel.java:819)
>        at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:164)
>        at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:472)
>        at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:497)
>        at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989)
>        at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74)
>        at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30)
>        at java.base/java.lang.Thread.run(Thread.java:834)
> {code}



--
This message was sent by Atlassian Jira
(v8.20.1#820001)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org