You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Karl Fogel <kf...@newton.ch.collab.net> on 2002/09/06 19:25:56 UTC

Re: Why not hide .SVN dir on windows?

"Barry Scott" <ba...@ntlworld.com> writes:
> Its very annoying that commands find files in the .SVN directory under
> windows.
> 
> Use of a . file on Unix is too hide the .svn directory from normal view.
> 
> The hidden attribute can be set on the .svn dir on windows to get the
> same feature.
> 
> Should I raise an issue for this?

Yeah!  Should be an easy patch, too, want to try it?

-Karl

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Why not hide .SVN dir on windows?

Posted by Karl Fogel <kf...@newton.ch.collab.net>.
Branko Čibej <br...@xbc.nu> writes:
> Not even in your wildest dreams! IMO support for setting the hidden
> attribute should go into APR, see apr_file_attrs_set. You'll have to
> define a new constant, APR_FILE_ATTR_HIDDEN, and don't forget to
> handle it in all implementations of that function.

Yup, what Branko said.

This is really mostly a patch to APR, plus a minor patch to Subversion
to use the new functionality added to APR.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Why not hide .SVN dir on windows?

Posted by Karl Fogel <kf...@newton.ch.collab.net>.
Nice analysis, that pretty much resolves the question, yeah...

-K

"Barry Scott" <ba...@ntlworld.com> writes:
> 1. SVN works
> 2. Copying the work space with explorer must copy the
>    hidden files.
> 3. MSDEV Find in Files skips hidden files
> 4. DIR /S <filename> does not find files in .svn
> 5. Barry's Emacs does not find files in .svn
> 
> So far I have:
> 
> No test on 1.
> Pass on 2.
> Fail on 3. However MSDEV is typically configured to look for particular
>            file types. *.h,*.cpp etc. Its does not need the change.
> Fail on 4. Need to set hidden on ever file in .svn to make them
>            vanish from dir /s
> Fail on 5. 
> 
> I conclude that its not worth changing svn because of fails on (3) and
> (5) and the extra complexity to fix (4).
> 
> I'm going to add code to my Emacs to deal with meta data directories
> like .svn and .cvs.
> 
> BArry
> 
> 
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Why not hide .SVN dir on windows?

Posted by Brian Huddleston <br...@huddleston.net>.
*chuckle*  Should've downloaded mail again before I replied. :-)

Sorry for the noise.

-Brian
----- Original Message -----
From: "Barry Scott" <ba...@ntlworld.com>
To: "SubversionDev" <de...@subversion.tigris.org>
Sent: Monday, September 09, 2002 4:11 PM
Subject: RE: Why not hide .SVN dir on windows?


> > >I know that I need to follow whats in HACKING. Looks
> > >like I'll add the windows code inside of #ifdef SVN_WIN32
> > >right?
> > >
> > >
> > Not even in your wildest dreams! IMO support for setting the hidden
> > attribute should go into APR, see apr_file_attrs_set. You'll have to
> > define a new constant, APR_FILE_ATTR_HIDDEN, and don't forget to handle
> > it in all implementations of that function.
>
> No problem. I thought it best to ask... Apart from the layer violation
> setting a file read-only might lost the hidden attr if its not done in
> the APR function.
>
> I have the svn client built and found where to set the hidden
> attrib. I've been working on the use cases. I think that at a minimum
> the following must work for this to be worth doing.
>
> 1. SVN works
> 2. Copying the work space with explorer must copy the
>    hidden files.
> 3. MSDEV Find in Files skips hidden files
> 4. DIR /S <filename> does not find files in .svn
> 5. Barry's Emacs does not find files in .svn
>
> So far I have:
>
> No test on 1.
> Pass on 2.
> Fail on 3. However MSDEV is typically configured to look for particular
>            file types. *.h,*.cpp etc. Its does not need the change.
> Fail on 4. Need to set hidden on ever file in .svn to make them
>            vanish from dir /s
> Fail on 5.
>
> I conclude that its not worth changing svn because of fails on (3) and
> (5) and the extra complexity to fix (4).
>
> I'm going to add code to my Emacs to deal with meta data directories
> like .svn and .cvs.
>
> BArry
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
>
>
>



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

RE: Why not hide .SVN dir on windows?

Posted by Barry Scott <ba...@ntlworld.com>.
> >I know that I need to follow whats in HACKING. Looks
> >like I'll add the windows code inside of #ifdef SVN_WIN32
> >right?
> >  
> >
> Not even in your wildest dreams! IMO support for setting the hidden 
> attribute should go into APR, see apr_file_attrs_set. You'll have to 
> define a new constant, APR_FILE_ATTR_HIDDEN, and don't forget to handle 
> it in all implementations of that function.

No problem. I thought it best to ask... Apart from the layer violation
setting a file read-only might lost the hidden attr if its not done in
the APR function.

I have the svn client built and found where to set the hidden
attrib. I've been working on the use cases. I think that at a minimum
the following must work for this to be worth doing.

1. SVN works
2. Copying the work space with explorer must copy the
   hidden files.
3. MSDEV Find in Files skips hidden files
4. DIR /S <filename> does not find files in .svn
5. Barry's Emacs does not find files in .svn

So far I have:

No test on 1.
Pass on 2.
Fail on 3. However MSDEV is typically configured to look for particular
           file types. *.h,*.cpp etc. Its does not need the change.
Fail on 4. Need to set hidden on ever file in .svn to make them
           vanish from dir /s
Fail on 5. 

I conclude that its not worth changing svn because of fails on (3) and
(5) and the extra complexity to fix (4).

I'm going to add code to my Emacs to deal with meta data directories
like .svn and .cvs.

BArry



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: Why not hide .SVN dir on windows?

Posted by Branko Čibej <br...@xbc.nu>.
Barry Scott wrote:

>O.k. I'll try. I've not attempted to build svn on windows
>yet, that should be fun.
>
>I know that I need to follow whats in HACKING. Looks
>like I'll add the windows code inside of #ifdef SVN_WIN32
>right?
>  
>
Not even in your wildest dreams! IMO support for setting the hidden 
attribute should go into APR, see apr_file_attrs_set. You'll have to 
define a new constant, APR_FILE_ATTR_HIDDEN, and don't forget to handle 
it in all implementations of that function.


-- 
Brane Čibej   <br...@xbc.nu>   http://www.xbc.nu/brane/


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

RE: Why not hide .SVN dir on windows?

Posted by Barry Scott <ba...@ntlworld.com>.
O.k. I'll try. I've not attempted to build svn on windows
yet, that should be fun.

I know that I need to follow whats in HACKING. Looks
like I'll add the windows code inside of #ifdef SVN_WIN32
right?

	BArry

> Yeah!  Should be an easy patch, too, want to try it?
> 
> -Karl
> 
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
> 
> 


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org