[jira] [Comment Edited] (PLC4X-286) Add profinet-DCP

["Adrian Lazar (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PLC4X-286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17302687#comment-17302687 ] 

Adrian Lazar edited comment on PLC4X-286 at 3/16/21, 4:55 PM:
--------------------------------------------------------------

I have used Windows 10 as I already have WinPCP installed probably due to installing Profinet Commander Free version for trying out the profinet-dcp. 

I have managed to run mvn install and have all the plc4x locally installed. 

Now looking into the sandbox directory, the test-java-profinet-driver project fails all the 8 ProfinetDCPBlock.xml tests. Is it because I don't have the real hardware?
Here's the output of a single test:

{{[ERROR] Tests run: 8, Failures: 0, Errors: 8, Skipped: 0, Time elapsed: 0.962 s <<< FAILURE! - in org.apache.plc4x.java.profinet.dcp.ProfinetDCPBlockTest
[ERROR] getTestsuiteTests[1] Time elapsed: 0.502 s <<< ERROR!
java.lang.IndexOutOfBoundsException: Index: 0, Size: 0}}

Are the test cases suppose to fail?
Or do you think it is a Windows limitation and I should try it out on Linux?

FYI, I will be looking into the following open-sources on how they managed to implement the profinet-dcp:
 * [python application|https://github.com/dark-lbp/isf/blob/master/icssploit/protocols/pn_dcp.py]
 * [C# application|https://sourceforge.net/projects/profinetexplorer/]
 * [rt-labs docs|https://rt-labs.com/docs/p-net/profinet_details.html]
 * [NodeJS app - as a last resort maybe|https://github.com/ktemelkov/node-profinetdcp]


was (Author: adrlzr):
The current OS is Windows 10 & already have WinPCP installed probably due to installing Profinet Commander Free version for trying out the profinet-dcp. 

I have managed to run mvn install and have all the plc4x locally installed. 

Now looking into the sandbox directory, the test-java-profinet-driver project fails all the 8 ProfinetDCPBlock.xml tests. Is it because I don't have the real hardware?
Here's the output of a single test:

{{[ERROR] Tests run: 8, Failures: 0, Errors: 8, Skipped: 0, Time elapsed: 0.962 s <<< FAILURE! - in org.apache.plc4x.java.profinet.dcp.ProfinetDCPBlockTest
[ERROR] getTestsuiteTests[1] Time elapsed: 0.502 s <<< ERROR!
java.lang.IndexOutOfBoundsException: Index: 0, Size: 0}}

Are the test cases suppose to fail?
Or do you think it is a Windows limitation and I should try it out on Linux?

FYI, I will be looking into the following open-sources on how they managed to implement the profinet-dcp:
 * [python application|https://github.com/dark-lbp/isf/blob/master/icssploit/protocols/pn_dcp.py]
 * [C# application|https://sourceforge.net/projects/profinetexplorer/]
 * [rt-labs docs|https://rt-labs.com/docs/p-net/profinet_details.html]
 * [NodeJS app - as a last resort maybe|https://github.com/ktemelkov/node-profinetdcp]

> Add profinet-DCP
> ----------------
>
>                 Key: PLC4X-286
>                 URL: https://issues.apache.org/jira/browse/PLC4X-286
>             Project: Apache PLC4X
>          Issue Type: Improvement
>          Components: Driver-Ethernet/IP, Driver-Profinet, Driver-S7
>    Affects Versions: 0.9.0
>            Reporter: Adrian Lazar
>            Priority: Major
>              Labels: beginner, feature, question
>
> I found some work done towards implementing the [profinet-DCP|https://profinetuniversity.com/naming-addressing/profinet-dcp/] protocol on the  [feature/profinet branch|[https://github.com/apache/plc4x/tree/feature/profinet]].
> I see that the profinet protocol is not on the develop branch anymore, was it replaced with the s7 protocol?
> If someone would have the time to guide me, I could work on it to update, test, and bring this discovery feature to PLC4X.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)