You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bigtop.apache.org by GitBox <gi...@apache.org> on 2020/04/27 07:08:39 UTC
[GitHub] [bigtop] guyuqi opened a new pull request #632: BIGTOP-3346: Introduce Ruby to Bigtop Toolchain
guyuqi opened a new pull request #632:
URL: https://github.com/apache/bigtop/pull/632
As discussion on [PR #620](https://github.com/apache/bigtop/pull/620) for BIGTOP-3319,
this PR is to introduce Ruby to Bigtop Toolchain for Logstash support.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] oflebbe commented on pull request #632: BIGTOP-3346: Introduce Ruby to Bigtop Toolchain
Posted by GitBox <gi...@apache.org>.
oflebbe commented on pull request #632:
URL: https://github.com/apache/bigtop/pull/632#issuecomment-622522026
Regarding centos7 we should use https://www.softwarecollections.org/en/scls/rhscl/rh-ruby26/ . This is a redhat provided service for RHEL and Centos.
Ubuntu 16.04 should be removed, since it is outdated. We should support 18.04 instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] guyuqi commented on pull request #632: BIGTOP-3346: Introduce Ruby to Bigtop Toolchain
Posted by GitBox <gi...@apache.org>.
guyuqi commented on pull request #632:
URL: https://github.com/apache/bigtop/pull/632#issuecomment-626318804
From the disscussion above, this PR would be abandoned.
For logstash, the ruby native package would not be installed in bigtop_toolchain.
Just support Logstash on the distros that provides Ruby 2.4+ for runtime. (distros: Ubuntu-18.04, Debian-10, Centos-8 and Fedora-31)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] oflebbe commented on pull request #632: BIGTOP-3346: Introduce Ruby to Bigtop Toolchain
Posted by GitBox <gi...@apache.org>.
oflebbe commented on pull request #632:
URL: https://github.com/apache/bigtop/pull/632#issuecomment-624187208
I agree @sekikn . All the platforms you are mentioning should be deprecated and therefore it should be ok to not provide new functionality.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] guyuqi commented on pull request #632: BIGTOP-3346: Introduce Ruby to Bigtop Toolchain
Posted by GitBox <gi...@apache.org>.
guyuqi commented on pull request #632:
URL: https://github.com/apache/bigtop/pull/632#issuecomment-620464186
> I prefer to have ruby from distro or rvm.
@oflebbe really thanks for your comments.
We do need the ruby-related facilities such as ruby rumtime, rake, gem and bundle to build logstash.
And for the Arm64 dependency issues, the ruby-2.4 is the latest version that works with logstash.
But ruby version is 2.0 in Centos 7 and 2.3 in ubuntu16.04.
When leveraging rvm to install ruby, rvm would pull the ruby binaries and spend less time than compiling ruby directly on x86_64.
But on Arm64, no ruby binaries are available and rvm would also download source code and compile ruby.
IMHO, our Bigtop should support different kind of distros and platforms(x86_64/arm64).
If ruby-2.4 were downloaded and compiled directly , it could guarantee that ruby-related facilities would be properly installed on the various distros and platforms though it may cost extra time just on x86 when building bigtop_toolchain. WDYT?
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] sekikn commented on pull request #632: BIGTOP-3346: Introduce Ruby to Bigtop Toolchain
Posted by GitBox <gi...@apache.org>.
sekikn commented on pull request #632:
URL: https://github.com/apache/bigtop/pull/632#issuecomment-623541638
Just my two cents, how about we only support Logstash on the distros that provides Ruby 2.4+ natively and doesn't on relatively old ones, i.e., CentOS 7, Debian 9 (which provides Ruby 2.3.3) and Ubuntu 16.04?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] guyuqi commented on pull request #632: BIGTOP-3346: Introduce Ruby to Bigtop Toolchain
Posted by GitBox <gi...@apache.org>.
guyuqi commented on pull request #632:
URL: https://github.com/apache/bigtop/pull/632#issuecomment-624425315
> I agree @sekikn . All the platforms you are mentioning should be deprecated and therefore it should be ok to not provide new functionality.
Yup, it makes sense. Thanks, @oflebbe @sekikn @evans-ye
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] oflebbe edited a comment on pull request #632: BIGTOP-3346: Introduce Ruby to Bigtop Toolchain
Posted by GitBox <gi...@apache.org>.
oflebbe edited a comment on pull request #632:
URL: https://github.com/apache/bigtop/pull/632#issuecomment-622522026
I do not get your argument, since the proposed change is to compile ruby for all platforms. I do not prefer to bring software already available for a platform as a native package in a suitable quality. For instance Debian, Ubuntu 18.04
Regarding centos7 we should use https://www.softwarecollections.org/en/scls/rhscl/rh-ruby26/ . This is a redhat provided service for RHEL and Centos and integrates nicely with Centos, AFAIK.
Ubuntu 16.04 should be removed, since it is outdated. We should support 18.04 instead.
If you find these are not compelling arguments, please go ahead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] evans-ye commented on pull request #632: BIGTOP-3346: Introduce Ruby to Bigtop Toolchain
Posted by GitBox <gi...@apache.org>.
evans-ye commented on pull request #632:
URL: https://github.com/apache/bigtop/pull/632#issuecomment-623149843
@guyuqi @oflebbe I think we can leverage Ruby on those platforms which already have ruby that meet the requirement. I'm guessing that most of the user just choose one arch X platform. If we compile our own dependencies, then user much do so in there env, which is not that ideal, does this make sense?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bigtop] evans-ye edited a comment on pull request #632: BIGTOP-3346: Introduce Ruby to Bigtop Toolchain
Posted by GitBox <gi...@apache.org>.
evans-ye edited a comment on pull request #632:
URL: https://github.com/apache/bigtop/pull/632#issuecomment-623149843
@guyuqi @oflebbe I think we can leverage Ruby on those platforms which already have ruby that meet the requirement. I'm guessing that most of the user just choose one arch X platform. If we compile our own dependencies, then user much do so in there env, which is not that ideal. Does this make sense?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org