You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Ning Zhang <nz...@fb.com> on 2011/04/12 00:36:06 UTC
Review Request: HIVE-2107. Log4J initialization info should not be printed
out if -S is specified
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/580/
-----------------------------------------------------------
Review request for hive.
Summary
-------
SessionState.initHiveLog4j() is called before hive command argument -S is parsed, so initHiveLog4j will printed out the init info even though -S is specified.
Diffs
-----
trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 1091220
trunk/ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 1091220
Diff: https://reviews.apache.org/r/580/diff
Testing
-------
Thanks,
Ning
Re: Review Request: HIVE-2107. Log4J initialization info should not be
printed out if -S is specified
Posted by namit jain <nj...@fb.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/580/#review427
-----------------------------------------------------------
Ship it!
- namit
On 2011-04-11 22:36:06, Ning Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/580/
> -----------------------------------------------------------
>
> (Updated 2011-04-11 22:36:06)
>
>
> Review request for hive.
>
>
> Summary
> -------
>
> SessionState.initHiveLog4j() is called before hive command argument -S is parsed, so initHiveLog4j will printed out the init info even though -S is specified.
>
>
> Diffs
> -----
>
> trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 1091220
> trunk/ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 1091220
>
> Diff: https://reviews.apache.org/r/580/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ning
>
>