You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "justfortaste (via GitHub)" <gi...@apache.org> on 2024/10/29 12:37:21 UTC
[PR] [fix](backup) fix backup confict with ddl [doris]
justfortaste opened a new pull request, #42872:
URL: https://github.com/apache/doris/pull/42872
The following DDL is forbidden during backup snapshot
- drop db
- drop table
- truncate table
- drop partition
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](backup) fix backup confict with ddl [doris]
Posted by "xy720 (via GitHub)" <gi...@apache.org>.
xy720 commented on code in PR #42872:
URL: https://github.com/apache/doris/pull/42872#discussion_r1874599342
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java:
##########
@@ -880,6 +884,20 @@ public void replayRenameDatabase(String dbName, String newDbName) {
LOG.info("replay rename database {} to {}", dbName, newDbName);
}
+ public void checkBuckupRunning(Database db, OlapTable olapTable) throws DdlException {
+ if (DebugPointUtil.isEnable("FE.checkBuckupRunning.ignore")) {
+ LOG.info("FE.checkBuckupRunning.ignore");
+ return;
+ }
+
+ BackupJob backupJob = (BackupJob) Env.getCurrentEnv().getBackupHandler().getJob(db.getId());
Review Comment:
getBackupHandler().getJob() is possible to return a Restore Job
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](backup) fix backup confict with ddl [doris]
Posted by "justfortaste (via GitHub)" <gi...@apache.org>.
justfortaste commented on PR #42872:
URL: https://github.com/apache/doris/pull/42872#issuecomment-2524837417
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](backup) fix backup confict with ddl [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42872:
URL: https://github.com/apache/doris/pull/42872#issuecomment-2964597633
We're closing this PR because it hasn't been updated in a while.
This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and feel free a maintainer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](backup) fix backup confict with ddl [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #42872: [fix](backup) fix backup confict with ddl
URL: https://github.com/apache/doris/pull/42872
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](backup) fix backup confict with ddl [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42872:
URL: https://github.com/apache/doris/pull/42872#issuecomment-2526180812
TeamCity be ut coverage result:
Function Coverage: 38.49% (10007/26002)
Line Coverage: 29.50% (83887/284391)
Region Coverage: 28.61% (43127/150758)
Branch Coverage: 25.20% (21921/86988)
Coverage Report: http://coverage.selectdb-in.cc/coverage/30c6ec5a4c93a2518f4bcc2967b09083f50b8a44_30c6ec5a4c93a2518f4bcc2967b09083f50b8a44/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](backup) fix backup confict with ddl [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42872:
URL: https://github.com/apache/doris/pull/42872#issuecomment-2520786115
TeamCity be ut coverage result:
Function Coverage: 38.48% (10005/26003)
Line Coverage: 29.51% (83895/284319)
Region Coverage: 28.61% (43115/150710)
Branch Coverage: 25.20% (21916/86966)
Coverage Report: http://coverage.selectdb-in.cc/coverage/e034f1dab3a59d463d630ce90d415e9233846ad3_e034f1dab3a59d463d630ce90d415e9233846ad3/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](backup) fix backup confict with ddl [doris]
Posted by "justfortaste (via GitHub)" <gi...@apache.org>.
justfortaste commented on PR #42872:
URL: https://github.com/apache/doris/pull/42872#issuecomment-2520648185
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](backup) fix backup confict with ddl [doris]
Posted by "xy720 (via GitHub)" <gi...@apache.org>.
xy720 commented on code in PR #42872:
URL: https://github.com/apache/doris/pull/42872#discussion_r1874612310
##########
fe/fe-core/src/main/java/org/apache/doris/datasource/InternalCatalog.java:
##########
@@ -880,6 +885,22 @@ public void replayRenameDatabase(String dbName, String newDbName) {
LOG.info("replay rename database {} to {}", dbName, newDbName);
}
+ public void checkBuckupRunning(Database db, OlapTable olapTable) throws DdlException {
Review Comment:
```suggestion
public void checkBackupRunning(Database db, OlapTable olapTable) throws DdlException {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](backup) fix backup confict with ddl [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42872:
URL: https://github.com/apache/doris/pull/42872#issuecomment-2524850341
TeamCity be ut coverage result:
Function Coverage: 38.49% (10007/26002)
Line Coverage: 29.50% (83888/284390)
Region Coverage: 28.60% (43122/150751)
Branch Coverage: 25.20% (21919/86986)
Coverage Report: http://coverage.selectdb-in.cc/coverage/348b4b71330bc22313e03e1e1d72763a27ba6018_348b4b71330bc22313e03e1e1d72763a27ba6018/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](backup) fix backup confict with ddl [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42872:
URL: https://github.com/apache/doris/pull/42872#issuecomment-2524983371
TeamCity be ut coverage result:
Function Coverage: 38.49% (10007/26002)
Line Coverage: 29.51% (83919/284390)
Region Coverage: 28.60% (43121/150751)
Branch Coverage: 25.20% (21921/86986)
Coverage Report: http://coverage.selectdb-in.cc/coverage/1a817b600817dcd5a8d863071ac4ba8d637e8d20_1a817b600817dcd5a8d863071ac4ba8d637e8d20/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](backup) fix backup confict with ddl [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42872:
URL: https://github.com/apache/doris/pull/42872#issuecomment-2540695179
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](backup) fix backup confict with ddl [doris]
Posted by "justfortaste (via GitHub)" <gi...@apache.org>.
justfortaste commented on PR #42872:
URL: https://github.com/apache/doris/pull/42872#issuecomment-2525414294
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](backup) fix backup confict with ddl [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42872:
URL: https://github.com/apache/doris/pull/42872#issuecomment-2444094168
Thank you for your contribution to Apache Doris.
Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR)
Since 2024-03-18, the Document has been moved to [doris-website](https://github.com/apache/doris-website).
See [Doris Document](https://cwiki.apache.org/confluence/display/DORIS/Doris+Document).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](backup) fix backup confict with ddl [doris]
Posted by "justfortaste (via GitHub)" <gi...@apache.org>.
justfortaste commented on PR #42872:
URL: https://github.com/apache/doris/pull/42872#issuecomment-2526128260
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](backup) fix backup confict with ddl [doris]
Posted by "justfortaste (via GitHub)" <gi...@apache.org>.
justfortaste commented on PR #42872:
URL: https://github.com/apache/doris/pull/42872#issuecomment-2540683701
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](backup) fix backup confict with ddl [doris]
Posted by "justfortaste (via GitHub)" <gi...@apache.org>.
justfortaste commented on PR #42872:
URL: https://github.com/apache/doris/pull/42872#issuecomment-2524970711
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](backup) fix backup confict with ddl [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42872:
URL: https://github.com/apache/doris/pull/42872#issuecomment-2525422080
TeamCity be ut coverage result:
Function Coverage: 38.48% (10006/26002)
Line Coverage: 29.51% (83911/284391)
Region Coverage: 28.60% (43118/150758)
Branch Coverage: 25.20% (21918/86988)
Coverage Report: http://coverage.selectdb-in.cc/coverage/30c6ec5a4c93a2518f4bcc2967b09083f50b8a44_30c6ec5a4c93a2518f4bcc2967b09083f50b8a44/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](backup) fix backup confict with ddl [doris]
Posted by "doris-robot (via GitHub)" <gi...@apache.org>.
doris-robot commented on PR #42872:
URL: https://github.com/apache/doris/pull/42872#issuecomment-2540769994
TeamCity be ut coverage result:
Function Coverage: 38.76% (10109/26082)
Line Coverage: 29.70% (84875/285767)
Region Coverage: 28.76% (43565/151452)
Branch Coverage: 25.32% (22133/87418)
Coverage Report: http://coverage.selectdb-in.cc/coverage/cbf09f01cb03fc681f40326c55df3dfc3eb0a06b_cbf09f01cb03fc681f40326c55df3dfc3eb0a06b/report/index.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] [fix](backup) fix backup confict with ddl [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #42872:
URL: https://github.com/apache/doris/pull/42872#issuecomment-2447124951
clang-tidy review says "All clean, LGTM! :+1:"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org