You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/10/09 15:39:10 UTC
[GitHub] [fineract] bharathcgowda opened a new pull request #1376: FINERACT-1165
bharathcgowda opened a new pull request #1376:
URL: https://github.com/apache/fineract/pull/1376
FINERACT-1165
**resending the PR**
When tested the load capacity on the platform for the savings module with 40k accounts along with around 100 Transactions for each account, it takes approx 45 Sec to bring up a savings account.
further identified the solution that adding an index to a column "savings_account_transaction_id" of table "m_note" would fix the issue.
This Pull request contains a flyway script to add indexing to the m_note table's savings_account_transaction_id column.
Note:
I have used the Version number as V363 as the latest on develop branch was V362.
Not sure how we are maintaining and picking the numbers in series, please let me know if V363 is already taken and to which number I can change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1376: FINERACT-1165
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1376:
URL: https://github.com/apache/fineract/pull/1376#issuecomment-711031197
@bharathcgowda this failed again after your force push, still due to Spotless. It looks like you probably forgot to `git add .` and `git commit --amend` before you pushed? The `./gradlew spotlessApply` actually fixes up the wrong formatting of your new SQL file, so after running Spotless, you need to add the file to git again, and update the commit, then force push it. Hope this makes sense?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1376: FINERACT-1165
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1376:
URL: https://github.com/apache/fineract/pull/1376#issuecomment-706310563
@bharathcgowda no problem at all, just trying to help you get started here (so that you can do more in the future!). Unfortunately your build failed again. Can you spot what's causing the problem, and do you know how to fix it, and this time update this existing PR? We are happy to help if you need assistance with any step, please just ask - the goal here is to do support you, so that you can contribute more.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] bharathcgowda commented on pull request #1376: FINERACT-1165
Posted by GitBox <gi...@apache.org>.
bharathcgowda commented on pull request #1376:
URL: https://github.com/apache/fineract/pull/1376#issuecomment-706838908
Thank you manthan, I figured it out through the build error, but couldn't
resend it on the weekend, I'll do it today.
On Mon, Oct 12, 2020, 3:47 AM Manthan Surkar <no...@github.com>
wrote:
> @bharathcgowda <https://github.com/bharathcgowda> were you able to find
> the problem? If not, you might want to look into this
> https://github.com/apache/fineract#checkstyle-and-spotless we are using
> spotless to maintain code quality and a simple run of a command ./gradlew
> spotlessApply should fix your problem ;)
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/fineract/pull/1376#issuecomment-706776162>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/APXFWFLHUVYRHAO4YHFOMKLSKIVJNANCNFSM4SKHMX4A>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] bharathcgowda commented on pull request #1376: FINERACT-1165
Posted by GitBox <gi...@apache.org>.
bharathcgowda commented on pull request #1376:
URL: https://github.com/apache/fineract/pull/1376#issuecomment-708523023
@thesmallstar Build failed again failed with the same error, I tried deleting the branch in my repo for force pushing again, but the PR has been closed. :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] thesmallstar edited a comment on pull request #1376: FINERACT-1165
Posted by GitBox <gi...@apache.org>.
thesmallstar edited a comment on pull request #1376:
URL: https://github.com/apache/fineract/pull/1376#issuecomment-708621767
@bharathcgowda thanks,
You can try this:
1. Run - ./gradlew spotlessApply
2. Run - ./gradlew clean build
Ensure that the build is successful and then force push on this branch, it is also a good idea to keep your code updated with that of upstream run: **git pull upstream develop --rebase**, this will bring new changes from the upstream and put your changes on the top.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] bharathcgowda closed pull request #1376: FINERACT-1165
Posted by GitBox <gi...@apache.org>.
bharathcgowda closed pull request #1376:
URL: https://github.com/apache/fineract/pull/1376
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] bharathcgowda commented on pull request #1376: FINERACT-1165
Posted by GitBox <gi...@apache.org>.
bharathcgowda commented on pull request #1376:
URL: https://github.com/apache/fineract/pull/1376#issuecomment-706294230
@vorburger I Apologies for creating the confusion, I was completely unaware of the process for PR corrections here, I'll do my best from next time, Thank you for helping me out here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] thesmallstar commented on pull request #1376: FINERACT-1165
Posted by GitBox <gi...@apache.org>.
thesmallstar commented on pull request #1376:
URL: https://github.com/apache/fineract/pull/1376#issuecomment-708621767
@bharathcgowda thanks,
You can try this:
1. Run - ./gradlew spotlessApply
2. Run - ./gradlew clean build
Ensure that the build is successful and then force push on this branch, it is also a good idea to keep your code updated with that of **git pull upstream develop --rebase**, this will bring new changes from the upstream and put your changes on the top.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger merged pull request #1376: FINERACT-1165
Posted by GitBox <gi...@apache.org>.
vorburger merged pull request #1376:
URL: https://github.com/apache/fineract/pull/1376
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] thesmallstar edited a comment on pull request #1376: FINERACT-1165
Posted by GitBox <gi...@apache.org>.
thesmallstar edited a comment on pull request #1376:
URL: https://github.com/apache/fineract/pull/1376#issuecomment-706776162
@bharathcgowda were you able to find the problem? If not, you might want to look into this https://github.com/apache/fineract#checkstyle-and-spotless we are using spotless to maintain code quality and a simple run of a command ./gradlew spotlessApply should fix your problem ;)
Edit: Another small suggestion, you might also want to write about what this issue solves in the PR name :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1376: FINERACT-1165
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1376:
URL: https://github.com/apache/fineract/pull/1376#issuecomment-706290708
@bharathcgowda this PR "looks" like it failed the build, with `fatal: couldn't find remote ref refs/pull/1374/merge`. That's however your OLD PR - apparently GitHub and/or TravisCI are getting confused here and mix up things... :imp: You now have [another build running](https://travis-ci.org/github/apache/fineract/builds/734335665), and I can merge this if that passes, but it's perhaps another good reason why for future contributions it's simplest not to Close and Open New PRs, but just amend (or force push) to the single one, as per comment over in #1374.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] bharathcgowda commented on pull request #1376: FINERACT-1165
Posted by GitBox <gi...@apache.org>.
bharathcgowda commented on pull request #1376:
URL: https://github.com/apache/fineract/pull/1376#issuecomment-715345374
Thank you @vorburger and @thesmallstar Finally both the checks have passed :)
Hope this PR can be merged now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] thesmallstar commented on pull request #1376: FINERACT-1165
Posted by GitBox <gi...@apache.org>.
thesmallstar commented on pull request #1376:
URL: https://github.com/apache/fineract/pull/1376#issuecomment-706776162
@bharathcgowda were you able to find the problem? If not, you might want to look into this https://github.com/apache/fineract#checkstyle-and-spotless we are using spotless to maintain code quality and a simple run of a command ./gradlew spotlessApply should fix your problem ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org