You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@fineract.apache.org by "Adam Saghy (Jira)" <ji...@apache.org> on 2022/08/09 09:23:00 UTC

[jira] [Commented] (FINERACT-1670) Introduce Auditable entities - Storing date time in UTC

    [ https://issues.apache.org/jira/browse/FINERACT-1670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17577300#comment-17577300 ] 

Adam Saghy commented on FINERACT-1670:
--------------------------------------

PR:

[https://github.com/apache/fineract/pull/2407]

[GitHub Pull Request #2482|https://github.com/apache/fineract/pull/2482]

[https://github.com/apache/fineract/pull/2418]

[https://github.com/apache/fineract/pull/2468] 

[https://github.com/apache/fineract/pull/2467] 

[https://github.com/apache/fineract/pull/2444] 

> Introduce Auditable entities - Storing date time in UTC
> -------------------------------------------------------
>
>                 Key: FINERACT-1670
>                 URL: https://issues.apache.org/jira/browse/FINERACT-1670
>             Project: Apache Fineract
>          Issue Type: Improvement
>    Affects Versions: 1.7.0
>            Reporter: Adam Saghy
>            Assignee: Adam Saghy
>            Priority: Major
>         Attachments: Re_ Timezone issues with Daylight savings.rtfd.zip
>
>
> AbstractAuditableCustom interface to be used more widely with entities.
> Many Fineract entity has no proper audit fields (creation date & time, last modification date & time, created by, modified by entries.
> Many entities has a variety of the above fields but with custom implementation and not fit perfectly for audit purposes (see LoanTransaction).
> All business entity ( utility entities excluded) should implement the above interface and fill properly the audit fields with a common, generic way.
> The similar custom fields to be removed / repurposed.
> The Datetime fields to be stored in UTC! The datetime fields when its fetched from the DB it is UTC, so it needs to be converted to the proper tenant timezone if there is any business logic attached to them.
>  
> Storing in UTC is important to avoid daylight savings and "incorrect timezone is used" issues:
> - Some places the tenant timezone used
> - Som places the system timezone used
>  
> *Acceptance criteria*
>  * Every custom fields with similar purpose to be decommissioned
>  * All datetime field to be utc
>  * It must be a backward-compatible change!
>  ** Column cannot be removed!
> *Change proposal*
>  * created_on_utc: Timezone aware datetime field
>  * last_modified_on_utc: Timezone aware datetime field
>  * created_by: Long (AppUser id)
>  * last_modified_by: Lond (AppUser id)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)