You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/14 13:48:48 UTC
[GitHub] [arrow] ianmcook commented on a change in pull request #10520: ARROW-12709: [C++] Add var_args_join
ianmcook commented on a change in pull request #10520:
URL: https://github.com/apache/arrow/pull/10520#discussion_r650963788
##########
File path: docs/source/cpp/compute.rst
##########
@@ -682,17 +682,23 @@ String joining
This function does the inverse of string splitting.
-+-----------------+-----------+----------------------+----------------+-------------------+---------+
-| Function name | Arity | Input type 1 | Input type 2 | Output type | Notes |
-+=================+===========+======================+================+===================+=========+
-| binary_join | Binary | List of string-like | String-like | String-like | \(1) |
-+-----------------+-----------+----------------------+----------------+-------------------+---------+
++-----------------+-----------+----------------------+----------------+-------------------+-----------------------+---------+
+| Function name | Arity | Input type 1 | Input type 2 | Output type | Options class | Notes |
++=================+===========+======================+================+===================+=======================+=========+
+| binary_join | Binary | List of string-like | String-like | String-like | | \(1) |
++-----------------+-----------+----------------------+----------------+-------------------+-----------------------+---------+
+| var_args_join | Varargs | List of string-like | (NA) | String-like | :struct:`JoinOptions` | \(2) |
Review comment:
For purposes of `var_args_join`, I interpret "Input type 1" mean "the type of the 1st through n-1st argument" and "Input type 2" to mean "the type of the nth argument". So I think the table should be like this:
```suggestion
| var_args_join | Varargs | String-like | String-like | String-like | :struct:`JoinOptions` | \(2) |
```
##########
File path: docs/source/cpp/compute.rst
##########
@@ -682,17 +682,23 @@ String joining
This function does the inverse of string splitting.
-+-----------------+-----------+----------------------+----------------+-------------------+---------+
-| Function name | Arity | Input type 1 | Input type 2 | Output type | Notes |
-+=================+===========+======================+================+===================+=========+
-| binary_join | Binary | List of string-like | String-like | String-like | \(1) |
-+-----------------+-----------+----------------------+----------------+-------------------+---------+
++-----------------+-----------+----------------------+----------------+-------------------+-----------------------+---------+
+| Function name | Arity | Input type 1 | Input type 2 | Output type | Options class | Notes |
++=================+===========+======================+================+===================+=======================+=========+
+| binary_join | Binary | List of string-like | String-like | String-like | | \(1) |
++-----------------+-----------+----------------------+----------------+-------------------+-----------------------+---------+
+| var_args_join | Varargs | List of string-like | (NA) | String-like | :struct:`JoinOptions` | \(2) |
Review comment:
For purposes of `var_args_join`, I interpret "Input type 1" to mean "the type of the 1st through n-1st argument" and "Input type 2" to mean "the type of the nth argument". So I think the table should be like this:
```suggestion
| var_args_join | Varargs | String-like | String-like | String-like | :struct:`JoinOptions` | \(2) |
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org