[GitHub] [hbase] gjacoby126 commented on a change in pull request #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend

[GitBox <gi...@apache.org>]

gjacoby126 commented on a change in pull request #390: HBASE-22623 - Add RegionObserver coprocessor hook for preWALAppend
URL: https://github.com/apache/hbase/pull/390#discussion_r311857487
 
 

 ##########
 File path: hbase-server/src/main/java/org/apache/hadoop/hbase/coprocessor/RegionObserver.java
 ##########
 @@ -1104,4 +1104,16 @@ default DeleteTracker postInstantiateDeleteTracker(
       throws IOException {
     return delTracker;
   }
+
+  /**
+   * Called just before the WAL Entry is appended to the WAL. Implementing this hook allows
+   * coprocessors to add extended attributes to the WALKey that then get persisted to the
+   * WAL, and are available to replication endpoints to use in processing WAL Entries.
+   * @param ctx the environment provided by the region server
+   * @param key the WALKey associated with a particular append to a WAL
+   */
+  default void preWALAppend(ObserverContext<RegionCoprocessorEnvironment> ctx, WALKey key,
 
 Review comment:
   @Apache9 Just to make sure I understand you right...you want me to write a method which is Deprecated, as of the moment of its creation? 
   
   Adding a method to a public interface tells people they can use it. Deprecating a method tells people they should stop using it or refrain from starting to. Adding a deprecated method...just adds dead code.
   
   Someday soon, there's going to be a Phoenix code review for changes I'll make that use this method, and someone's going to say, "You can't use this method; it's deprecated. -1" And they'll be completely right to say so. 
   
   Huh?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services