[GitHub] [doris] EmmyMiao87 commented on a diff in pull request #10848: [fix](planner)nullable info in IntermediateTuple do not be serialized in hash join node

[GitBox <gi...@apache.org>]

EmmyMiao87 commented on code in PR #10848:
URL: https://github.com/apache/doris/pull/10848#discussion_r921037760


##########
fe/fe-core/src/main/java/org/apache/doris/planner/HashJoinNode.java:
##########
@@ -583,6 +583,7 @@ private void computeIntermediateTuple(Analyzer analyzer) throws AnalysisExceptio
                 originToIntermediateSmap.put(new SlotRef(slotDescriptor), new SlotRef(intermediateSlotDesc));
             }
         }

Review Comment:
   The last calculation is enough, no need to repeat the calculation



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org