[GitHub] [solr] stillalex commented on a diff in pull request #1564: SOLR-16601: remove deprecated code in Solr Clients

["stillalex (via GitHub)" <gi...@apache.org>]

stillalex commented on code in PR #1564:
URL: https://github.com/apache/solr/pull/1564#discussion_r1174077500


##########
solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java:
##########
@@ -1290,20 +1240,6 @@ public ResponseParser getParser() {
     return parser;
   }
 
-  /**
-   * Note: This setter method is <b>not thread-safe</b>.
-   *
-   * @param parser Default Response Parser chosen to parse the response if the parser were not
-   *     specified as part of the request.
-   * @see org.apache.solr.client.solrj.SolrRequest#getResponseParser()
-   * @deprecated use {@link Http2SolrClient.Builder#withResponseParser(ResponseParser)} instead
-   */
-  @Deprecated
-  public void setParser(ResponseParser parser) {
-    this.parser = parser;
-    updateDefaultMimeTypeForParser();

Review Comment:
   @epugh this breaks update of default mime types functionality. code needs to go via the setter when updating the parser so  `updateDefaultMimeTypeForParser` is always called otherwise that set becomes stale, I am working on a patch for SOLR-16737 and will add it back. fyi @tflobbe 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org