You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Richard Liang (JIRA)" <ji...@apache.org> on 2006/12/01 08:57:23 UTC
[jira] Closed: (HARMONY-2356) [classlib][luni]The Map from
System.getEnv should throw NullPointerException while get(null) and is not
modifiable.
[ http://issues.apache.org/jira/browse/HARMONY-2356?page=all ]
Richard Liang closed HARMONY-2356.
----------------------------------
Verified by Leo
> [classlib][luni]The Map from System.getEnv should throw NullPointerException while get(null) and is not modifiable.
> -------------------------------------------------------------------------------------------------------------------
>
> Key: HARMONY-2356
> URL: http://issues.apache.org/jira/browse/HARMONY-2356
> Project: Harmony
> Issue Type: Bug
> Reporter: Leo Li
> Assigned To: Richard Liang
> Attachments: patch-2356.diff, patch-2356.diff
>
>
> Here is the testcase:
> public void testUnmodifiableMap()
> {
> Map map = System.getEnv();
>
> try {
> map.get(null);
> fail("Should throw NullPointerExcepiton.");
> } catch (NullPointerException e) {
> //expected
> }
>
> }
> RI passes.
> Harmony fails.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
Re: [jira] Closed: (HARMONY-2356) [classlib][luni]The Map from System.getEnv
should throw NullPointerException while get(null) and is not modifiable.
Posted by "Geir Magnusson Jr." <ge...@pobox.com>.
fixed and committed. Thanks.
I looked, but it seems that the luni SystemTest was never excluded for
DRLVM. I'll try to verify before I have to get on a train later, but if
someone else can too, that would be cool.
geir
Geir Magnusson Jr. wrote:
> I'll get it in now. I linked it to HARMONY-2356.
>
> geir
>
> Alexey Varlamov wrote:
>> Created HARMONY-2390.
>>
>> 2006/12/1, Alexey Varlamov <al...@gmail.com>:
>>> The test is correct and this is DRLVM-specific issue. Therefore it
>>> should be excluded for DRLVM only and a JIRA against DRLVM filed.
>>> That's the point of per-VM exclusion lists, I believe.
>>>
>>> --
>>> Alexey
>>>
>>>
>>> 2006/12/1, Mikhail Loenko <ml...@gmail.com>:
>>> > The bug was fixed for J9. It's still reproducible on DRLVM (there is
>>> > some code duplicate between DRLVM and classlib).
>>> >
>>> > So we may:
>>> > 1) exclude this test for DRLVM until code duplicate is resolved
>>> > or
>>> > 2) remove this test until the bug is fixed for DRLVM also
>>> >
>>> > Suggestions?
>>> >
>>> > Thanks,
>>> > Mikhail
>>> >
>>> > 2006/12/1, Richard Liang (JIRA) <ji...@apache.org>:
>>> > > [ http://issues.apache.org/jira/browse/HARMONY-2356?page=all ]
>>> > >
>>> > > Richard Liang closed HARMONY-2356.
>>> > > ----------------------------------
>>> > >
>>> > >
>>> > > Verified by Leo
>>> > >
>>> > > > [classlib][luni]The Map from System.getEnv should throw
>>> NullPointerException while get(null) and is not modifiable.
>>> > > >
>>> -------------------------------------------------------------------------------------------------------------------
>>>
>>> > > >
>>> > > > Key: HARMONY-2356
>>> > > > URL:
>>> http://issues.apache.org/jira/browse/HARMONY-2356
>>> > > > Project: Harmony
>>> > > > Issue Type: Bug
>>> > > > Reporter: Leo Li
>>> > > > Assigned To: Richard Liang
>>> > > > Attachments: patch-2356.diff, patch-2356.diff
>>> > > >
>>> > > >
>>> > > > Here is the testcase:
>>> > > > public void testUnmodifiableMap()
>>> > > > {
>>> > > > Map map = System.getEnv();
>>> > > >
>>> > > > try {
>>> > > > map.get(null);
>>> > > > fail("Should throw NullPointerExcepiton.");
>>> > > > } catch (NullPointerException e) {
>>> > > > //expected
>>> > > > }
>>> > > >
>>> > > > }
>>> > > > RI passes.
>>> > > > Harmony fails.
>>> > >
>>> > > --
>>> > > This message is automatically generated by JIRA.
>>> > > -
>>> > > If you think it was sent incorrectly contact one of the
>>> administrators: http://issues.apache.org/jira/secure/Administrators.jspa
>>> > > -
>>> > > For more information on JIRA, see:
>>> http://www.atlassian.com/software/jira
>>> > >
>>> > >
>>> > >
>>> >
>>>
Re: [jira] Closed: (HARMONY-2356) [classlib][luni]The Map from System.getEnv
should throw NullPointerException while get(null) and is not modifiable.
Posted by "Geir Magnusson Jr." <ge...@pobox.com>.
I'll get it in now. I linked it to HARMONY-2356.
geir
Alexey Varlamov wrote:
> Created HARMONY-2390.
>
> 2006/12/1, Alexey Varlamov <al...@gmail.com>:
>> The test is correct and this is DRLVM-specific issue. Therefore it
>> should be excluded for DRLVM only and a JIRA against DRLVM filed.
>> That's the point of per-VM exclusion lists, I believe.
>>
>> --
>> Alexey
>>
>>
>> 2006/12/1, Mikhail Loenko <ml...@gmail.com>:
>> > The bug was fixed for J9. It's still reproducible on DRLVM (there is
>> > some code duplicate between DRLVM and classlib).
>> >
>> > So we may:
>> > 1) exclude this test for DRLVM until code duplicate is resolved
>> > or
>> > 2) remove this test until the bug is fixed for DRLVM also
>> >
>> > Suggestions?
>> >
>> > Thanks,
>> > Mikhail
>> >
>> > 2006/12/1, Richard Liang (JIRA) <ji...@apache.org>:
>> > > [ http://issues.apache.org/jira/browse/HARMONY-2356?page=all ]
>> > >
>> > > Richard Liang closed HARMONY-2356.
>> > > ----------------------------------
>> > >
>> > >
>> > > Verified by Leo
>> > >
>> > > > [classlib][luni]The Map from System.getEnv should throw
>> NullPointerException while get(null) and is not modifiable.
>> > > >
>> -------------------------------------------------------------------------------------------------------------------
>>
>> > > >
>> > > > Key: HARMONY-2356
>> > > > URL:
>> http://issues.apache.org/jira/browse/HARMONY-2356
>> > > > Project: Harmony
>> > > > Issue Type: Bug
>> > > > Reporter: Leo Li
>> > > > Assigned To: Richard Liang
>> > > > Attachments: patch-2356.diff, patch-2356.diff
>> > > >
>> > > >
>> > > > Here is the testcase:
>> > > > public void testUnmodifiableMap()
>> > > > {
>> > > > Map map = System.getEnv();
>> > > >
>> > > > try {
>> > > > map.get(null);
>> > > > fail("Should throw NullPointerExcepiton.");
>> > > > } catch (NullPointerException e) {
>> > > > //expected
>> > > > }
>> > > >
>> > > > }
>> > > > RI passes.
>> > > > Harmony fails.
>> > >
>> > > --
>> > > This message is automatically generated by JIRA.
>> > > -
>> > > If you think it was sent incorrectly contact one of the
>> administrators: http://issues.apache.org/jira/secure/Administrators.jspa
>> > > -
>> > > For more information on JIRA, see:
>> http://www.atlassian.com/software/jira
>> > >
>> > >
>> > >
>> >
>>
Re: [jira] Closed: (HARMONY-2356) [classlib][luni]The Map from System.getEnv should throw NullPointerException while get(null) and is not modifiable.
Posted by Alexey Varlamov <al...@gmail.com>.
Created HARMONY-2390.
2006/12/1, Alexey Varlamov <al...@gmail.com>:
> The test is correct and this is DRLVM-specific issue. Therefore it
> should be excluded for DRLVM only and a JIRA against DRLVM filed.
> That's the point of per-VM exclusion lists, I believe.
>
> --
> Alexey
>
>
> 2006/12/1, Mikhail Loenko <ml...@gmail.com>:
> > The bug was fixed for J9. It's still reproducible on DRLVM (there is
> > some code duplicate between DRLVM and classlib).
> >
> > So we may:
> > 1) exclude this test for DRLVM until code duplicate is resolved
> > or
> > 2) remove this test until the bug is fixed for DRLVM also
> >
> > Suggestions?
> >
> > Thanks,
> > Mikhail
> >
> > 2006/12/1, Richard Liang (JIRA) <ji...@apache.org>:
> > > [ http://issues.apache.org/jira/browse/HARMONY-2356?page=all ]
> > >
> > > Richard Liang closed HARMONY-2356.
> > > ----------------------------------
> > >
> > >
> > > Verified by Leo
> > >
> > > > [classlib][luni]The Map from System.getEnv should throw NullPointerException while get(null) and is not modifiable.
> > > > -------------------------------------------------------------------------------------------------------------------
> > > >
> > > > Key: HARMONY-2356
> > > > URL: http://issues.apache.org/jira/browse/HARMONY-2356
> > > > Project: Harmony
> > > > Issue Type: Bug
> > > > Reporter: Leo Li
> > > > Assigned To: Richard Liang
> > > > Attachments: patch-2356.diff, patch-2356.diff
> > > >
> > > >
> > > > Here is the testcase:
> > > > public void testUnmodifiableMap()
> > > > {
> > > > Map map = System.getEnv();
> > > >
> > > > try {
> > > > map.get(null);
> > > > fail("Should throw NullPointerExcepiton.");
> > > > } catch (NullPointerException e) {
> > > > //expected
> > > > }
> > > >
> > > > }
> > > > RI passes.
> > > > Harmony fails.
> > >
> > > --
> > > This message is automatically generated by JIRA.
> > > -
> > > If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
> > > -
> > > For more information on JIRA, see: http://www.atlassian.com/software/jira
> > >
> > >
> > >
> >
>
Re: [jira] Closed: (HARMONY-2356) [classlib][luni]The Map from System.getEnv should throw NullPointerException while get(null) and is not modifiable.
Posted by Alexey Varlamov <al...@gmail.com>.
The test is correct and this is DRLVM-specific issue. Therefore it
should be excluded for DRLVM only and a JIRA against DRLVM filed.
That's the point of per-VM exclusion lists, I believe.
--
Alexey
2006/12/1, Mikhail Loenko <ml...@gmail.com>:
> The bug was fixed for J9. It's still reproducible on DRLVM (there is
> some code duplicate between DRLVM and classlib).
>
> So we may:
> 1) exclude this test for DRLVM until code duplicate is resolved
> or
> 2) remove this test until the bug is fixed for DRLVM also
>
> Suggestions?
>
> Thanks,
> Mikhail
>
> 2006/12/1, Richard Liang (JIRA) <ji...@apache.org>:
> > [ http://issues.apache.org/jira/browse/HARMONY-2356?page=all ]
> >
> > Richard Liang closed HARMONY-2356.
> > ----------------------------------
> >
> >
> > Verified by Leo
> >
> > > [classlib][luni]The Map from System.getEnv should throw NullPointerException while get(null) and is not modifiable.
> > > -------------------------------------------------------------------------------------------------------------------
> > >
> > > Key: HARMONY-2356
> > > URL: http://issues.apache.org/jira/browse/HARMONY-2356
> > > Project: Harmony
> > > Issue Type: Bug
> > > Reporter: Leo Li
> > > Assigned To: Richard Liang
> > > Attachments: patch-2356.diff, patch-2356.diff
> > >
> > >
> > > Here is the testcase:
> > > public void testUnmodifiableMap()
> > > {
> > > Map map = System.getEnv();
> > >
> > > try {
> > > map.get(null);
> > > fail("Should throw NullPointerExcepiton.");
> > > } catch (NullPointerException e) {
> > > //expected
> > > }
> > >
> > > }
> > > RI passes.
> > > Harmony fails.
> >
> > --
> > This message is automatically generated by JIRA.
> > -
> > If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
> > -
> > For more information on JIRA, see: http://www.atlassian.com/software/jira
> >
> >
> >
>
Re: [jira] Closed: (HARMONY-2356) [classlib][luni]The Map from System.getEnv should throw NullPointerException while get(null) and is not modifiable.
Posted by Mikhail Loenko <ml...@gmail.com>.
The bug was fixed for J9. It's still reproducible on DRLVM (there is
some code duplicate between DRLVM and classlib).
So we may:
1) exclude this test for DRLVM until code duplicate is resolved
or
2) remove this test until the bug is fixed for DRLVM also
Suggestions?
Thanks,
Mikhail
2006/12/1, Richard Liang (JIRA) <ji...@apache.org>:
> [ http://issues.apache.org/jira/browse/HARMONY-2356?page=all ]
>
> Richard Liang closed HARMONY-2356.
> ----------------------------------
>
>
> Verified by Leo
>
> > [classlib][luni]The Map from System.getEnv should throw NullPointerException while get(null) and is not modifiable.
> > -------------------------------------------------------------------------------------------------------------------
> >
> > Key: HARMONY-2356
> > URL: http://issues.apache.org/jira/browse/HARMONY-2356
> > Project: Harmony
> > Issue Type: Bug
> > Reporter: Leo Li
> > Assigned To: Richard Liang
> > Attachments: patch-2356.diff, patch-2356.diff
> >
> >
> > Here is the testcase:
> > public void testUnmodifiableMap()
> > {
> > Map map = System.getEnv();
> >
> > try {
> > map.get(null);
> > fail("Should throw NullPointerExcepiton.");
> > } catch (NullPointerException e) {
> > //expected
> > }
> >
> > }
> > RI passes.
> > Harmony fails.
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>