You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/08/04 10:59:11 UTC

[GitHub] [echarts] Liangism opened a new issue, #17473: [Bug] 5.3.3版本使用主题文件出现警告信息

Liangism opened a new issue, #17473:
URL: https://github.com/apache/echarts/issues/17473

   ### Version
   
   5.3.3
   
   ### Link to Minimal Reproduction
   
   _No response_
   
   ### Steps to Reproduce
   
   1.使用npm安装echarts;
   2.使用示例默认的选项;
   3.引入了macarons,shine主题;
   
   ### Current Behavior
   
   在引入了shine主题文件后,在控制台出现警告信息:
   
   > [ECharts] DEPRECATED: 'normal' hierarchy in iconStyle has been removed since 4.0. All style properties are configured in iconStyle directly now.
   发现是theme/shine.js内toolbox配置项导致,并且macarons.js也有同样问题。
   ` toolbox: {
               iconStyle: {
                   normal: {
                       borderColor: '#06467c'
                   }
               }
           },`
   
   ### Expected Behavior
   
   希望不要出现这个警告了:)
   
   ### Environment
   
   ```markdown
   - OS:
   - Browser:
   - Framework:
   ```
   
   
   ### Any additional comments?
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] echarts-bot[bot] commented on issue #17473: [Bug]

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #17473:
URL: https://github.com/apache/echarts/issues/17473#issuecomment-1205099439

   I'm sorry to close this issue for it lacks the necessary title. Please provide **a _descriptive_ and as _concise_ as possible title to describe your problems or requests** and then the maintainers or I will reopen this issue.
   
   Every good bug report or feature request starts with a title. Your issue title is a critical element as it's the first thing maintainers see.
   
   A good issue title makes it easier for maintainers to understand what the issue is, easily locate it, and know what steps they'll need to take to fix it.
   
   Moreover, it's better to include keywords, as this makes it easier to find the issue self and similar issues in searches.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] plainheart commented on issue #17473: [Bug] 5.3.3版本使用主题文件出现警告信息

Posted by GitBox <gi...@apache.org>.
plainheart commented on issue #17473:
URL: https://github.com/apache/echarts/issues/17473#issuecomment-1205282060

   为了便于使用,减少配置项层级,早前取消了 `normal` 这个层级。大概是因为这个主题文件较早而忘记了更新为新的用法。如果感兴趣的话,欢迎提 PR 修正下~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] echarts-bot[bot] commented on issue #17473: [Bug] 5.3.3版本使用主题文件出现警告信息

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] commented on issue #17473:
URL: https://github.com/apache/echarts/issues/17473#issuecomment-1205100382

   @Liangism It seems you are not using English, I've helped translate the content automatically. To make your issue understood by more people and get helped, we'd like to suggest using English next time. 🤗
   <details><summary><b>TRANSLATED</b></summary><br>
   
   **TITLE**
   
   [Bug] Warning message appears when using theme file in version 5.3.3
   
   **BODY**
   
   ### Version
   
   5.3.3
   
   ### Link to Minimal Reproduction
   
   _No response_
   
   ### Steps to Reproduce
   
   1. Install echarts using npm;
   2. Use the default options of the example;
   3. Introduced macarons, shiny theme;
   
   ### Current Behavior
   
   After importing the shiny theme file, a warning message appears in the console:
   
   > [ECharts] DEPRECATED: 'normal' hierarchy in iconStyle has been removed since 4.0. All style properties are configured in iconStyle directly now.
   It was found that it was caused by the toolbox configuration item in theme/shine.js, and macarons.js also had the same problem.
   ` toolbox: {
               iconStyle: {
                   normal: {
                       borderColor: '#06467c'
                   }
               }
           },`
   
   ### Expected Behavior
   
   Hope this warning doesn't appear :)
   
   ### Environment
   
   ````markdown
   - OS:
   - Browser:
   - Framework:
   ````
   
   
   ### Any additional comments?
   
   _No response_
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] plainheart closed issue #17473: [Bug] 5.3.3版本使用主题文件出现警告信息

Posted by GitBox <gi...@apache.org>.
plainheart closed issue #17473: [Bug] 5.3.3版本使用主题文件出现警告信息
URL: https://github.com/apache/echarts/issues/17473


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] Liangism commented on issue #17473: [Bug] 5.3.3版本使用主题文件出现警告信息

Posted by GitBox <gi...@apache.org>.
Liangism commented on issue #17473:
URL: https://github.com/apache/echarts/issues/17473#issuecomment-1205953774

   > 为了便于使用,减少配置项层级,早前取消了 `normal` 这个层级。大概是因为这个主题文件较早而忘记了更新为新的用法。如果感兴趣的话,欢迎提 PR 修正下~
   
   😁好的,我已经将`theme`文件的`normal`替换了


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org


[GitHub] [echarts] echarts-bot[bot] closed issue #17473: [Bug]

Posted by GitBox <gi...@apache.org>.
echarts-bot[bot] closed issue #17473: [Bug] 
URL: https://github.com/apache/echarts/issues/17473


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org