You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by shea-parkes <gi...@git.apache.org> on 2017/01/04 15:59:27 UTC

[GitHub] spark pull request #16094: [SPARK-18541][Python]Add metadata parameter to py...

Github user shea-parkes commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16094#discussion_r94609053
  
    --- Diff: python/pyspark/sql/column.py ---
    @@ -298,19 +299,34 @@ def isin(self, *cols):
         isNotNull = _unary_op("isNotNull", "True if the current expression is not null.")
     
         @since(1.3)
    -    def alias(self, *alias):
    +    def alias(self, *alias, **kwargs):
             """
             Returns this column aliased with a new name or names (in the case of expressions that
             return more than one column, such as explode).
     
    +        Optional ``metadata`` keyword argument can be passed when aliasing a single column.
    --- End diff --
    
    Congrats on the release of v2.1.  I believe the `versionchanged` target of v2.2 is now accurate.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org