You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by GitBox <gi...@apache.org> on 2021/12/13 14:38:58 UTC

[GitHub] [accumulo] DomGarguilo commented on a change in pull request #2384: Fix IDE suggested string usage issues.

DomGarguilo commented on a change in pull request #2384:
URL: https://github.com/apache/accumulo/pull/2384#discussion_r767816143



##########
File path: test/src/main/java/org/apache/accumulo/test/functional/YieldingIterator.java
##########
@@ -95,8 +95,8 @@ public void next() throws IOException {
    */
   @Override
   public Value getTopValue() {
-    String value = Integer.toString(yieldNexts.get()) + ',' + Integer.toString(yieldSeeks.get())
-        + ',' + Integer.toString(rebuilds.get());
+    String value =
+        Integer.toString(yieldNexts.get()) + ',' + yieldSeeks.get() + ',' + rebuilds.get();

Review comment:
       ```suggestion
           yieldNexts.get() + "," + yieldSeeks.get() + "," + rebuilds.get();
   ```
   Could do this if we wanted to avoid using the first `Integer.toString` as well. Either way, LGTM.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org