You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2017/02/16 22:16:47 UTC
[kudu-CR] [security] add TLS protocol and cipher suite to negotiation trace
Hello Todd Lipcon, Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/6042
to review the following change.
Change subject: [security] add TLS protocol and cipher suite to negotiation trace
......................................................................
[security] add TLS protocol and cipher suite to negotiation trace
No tests, but I manually verified the output looks good:
0216 14:14:45.214356 (+ 48us) server_negotiation.cc:484] Negotiated TLSv1.2 with cipher suite AES256-GCM-SHA384
Change-Id: Ie1bf0d4cb8b683011e122a87b1856d718ba62331
---
M src/kudu/rpc/client_negotiation.cc
M src/kudu/rpc/server_negotiation.cc
M src/kudu/security/tls_handshake.cc
M src/kudu/security/tls_handshake.h
4 files changed, 28 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/42/6042/1
--
To view, visit http://gerrit.cloudera.org:8080/6042
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie1bf0d4cb8b683011e122a87b1856d718ba62331
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [security] add TLS protocol and cipher suite to negotiation trace
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged.
Change subject: [security] add TLS protocol and cipher suite to negotiation trace
......................................................................
[security] add TLS protocol and cipher suite to negotiation trace
No tests, but I manually verified the output looks good:
0216 14:14:45.214356 (+ 48us) server_negotiation.cc:484] Negotiated TLSv1.2 with cipher suite AES256-GCM-SHA384
Change-Id: Ie1bf0d4cb8b683011e122a87b1856d718ba62331
Reviewed-on: http://gerrit.cloudera.org:8080/6042
Tested-by: Kudu Jenkins
Reviewed-by: Dan Burkert <da...@apache.org>
---
M src/kudu/rpc/client_negotiation.cc
M src/kudu/rpc/server_negotiation.cc
M src/kudu/security/tls_handshake.cc
M src/kudu/security/tls_handshake.h
4 files changed, 28 insertions(+), 2 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/6042
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie1bf0d4cb8b683011e122a87b1856d718ba62331
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
[kudu-CR] [security] add TLS protocol and cipher suite to negotiation trace
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: [security] add TLS protocol and cipher suite to negotiation trace
......................................................................
Patch Set 2: Code-Review+2
Carrying over Alexey's +2 on the rebase.
--
To view, visit http://gerrit.cloudera.org:8080/6042
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1bf0d4cb8b683011e122a87b1856d718ba62331
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No
[kudu-CR] [security] add TLS protocol and cipher suite to negotiation trace
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change.
Change subject: [security] add TLS protocol and cipher suite to negotiation trace
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6042
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie1bf0d4cb8b683011e122a87b1856d718ba62331
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-HasComments: No