You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by dongjoon-hyun <gi...@git.apache.org> on 2018/05/28 16:02:31 UTC

[GitHub] spark pull request #21446: [SPARK-19613][SS][TEST] Random.nextString is not ...

GitHub user dongjoon-hyun opened a pull request:

    https://github.com/apache/spark/pull/21446

    [SPARK-19613][SS][TEST] Random.nextString is not safe for directory namePrefix

    ## What changes were proposed in this pull request?
    
    `Random.nextString` is good for generating random string data, but it's not suitable for directory name prefix. This PR uses more safe directory namePrefix.
    
    ```
    scala> scala.util.Random.nextString(10)
    res0: String = 馨쭔ᎰႻ穚䃈兩㻞藑並
    
    scala> scala.util.Random.nextInt.abs.toString
    res1: String = 1016732284
    ```
    
    ## How was this patch tested?
    
    Pass the Jenkins.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dongjoon-hyun/spark SPARK-19613

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/21446.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #21446
    
----
commit a46dc70d86a4f3f8387dc7c2125392de5a2cfb5e
Author: Dongjoon Hyun <do...@...>
Date:   2018-05-28T15:53:22Z

    [SPARK-19613][SS][TEST] Random.nextString is not safe for directory namePrefix

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21446: [SPARK-19613][SS][TEST] Random.nextString is not safe fo...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21446
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91231/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21446: [SPARK-19613][SS][TEST] Random.nextString is not safe fo...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21446
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21446: [SPARK-19613][SS][TEST] Random.nextString is not safe fo...

Posted by dongjoon-hyun <gi...@git.apache.org>.

Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/21446
  
    Thank you for review and merging, @HyukjinKwon . Thank you all!


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21446: [SPARK-19613][SS][TEST] Random.nextString is not safe fo...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21446
  
    **[Test build #91231 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91231/testReport)** for PR 21446 at commit [`a46dc70`](https://github.com/apache/spark/commit/a46dc70d86a4f3f8387dc7c2125392de5a2cfb5e).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21446: [SPARK-19613][SS][TEST] Random.nextString is not safe fo...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21446
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/91232/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21446: [SPARK-19613][SS][TEST] Random.nextString is not safe fo...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21446
  
    **[Test build #91232 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91232/testReport)** for PR 21446 at commit [`1412abd`](https://github.com/apache/spark/commit/1412abd694430d90a2740b142d29dbe1a2d07cec).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21446: [SPARK-19613][SS][TEST] Random.nextString is not safe fo...

Posted by HyukjinKwon <gi...@git.apache.org>.

Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/21446
  
    Yea, I was facing this problem too. Thanks for fixing this.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21446: [SPARK-19613][SS][TEST] Random.nextString is not safe fo...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21446
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21446: [SPARK-19613][SS][TEST] Random.nextString is not safe fo...

Posted by dongjoon-hyun <gi...@git.apache.org>.

Github user dongjoon-hyun commented on the issue:

    https://github.com/apache/spark/pull/21446
  
    Thank you for reviewing, @felixcheung and @HeartSaVioR.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21446: [SPARK-19613][SS][TEST] Random.nextString is not safe fo...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21446
  
    **[Test build #91232 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91232/testReport)** for PR 21446 at commit [`1412abd`](https://github.com/apache/spark/commit/1412abd694430d90a2740b142d29dbe1a2d07cec).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21446: [SPARK-19613][SS][TEST] Random.nextString is not safe fo...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21446
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/testing-k8s-prb-make-spark-distribution/3647/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21446: [SPARK-19613][SS][TEST] Random.nextString is not safe fo...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/21446
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #21446: [SPARK-19613][SS][TEST] Random.nextString is not safe fo...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/21446
  
    **[Test build #91231 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/91231/testReport)** for PR 21446 at commit [`a46dc70`](https://github.com/apache/spark/commit/a46dc70d86a4f3f8387dc7c2125392de5a2cfb5e).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org