You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/11/24 03:43:37 UTC

[GitHub] [iotdb] cornmonster opened a new pull request #4458: [IOTDB-1673] CLI refactor

cornmonster opened a new pull request #4458:
URL: https://github.com/apache/iotdb/pull/4458


   1. Upgrade to Jline3.
   2. Remove the CLI implementation for Windows since Jline3 is platform-independent.
   3. Support persisted command history.
   4. Support multi-line edition.
   ![image](https://user-images.githubusercontent.com/20107543/143170961-503577fa-6744-4064-b7c3-1209646ac0c6.png)
   
   
   5. Exit by pressing CTRL+D or CTRL+C twice.
   ![image](https://user-images.githubusercontent.com/20107543/143170813-4685d92c-9fe0-4420-aca3-0c85b47e2239.png)
   
   6. Add auto pair and autosuggestion widgets.
   ![image](https://user-images.githubusercontent.com/20107543/143170767-ab6653a6-6f85-4389-98e6-e8fef9fd8bbb.png)
   
   7. Add keyword highlighter and completer.
   ![image](https://user-images.githubusercontent.com/20107543/143171024-deeef6d4-ab5c-4b13-b71a-98eabc4b749c.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls edited a comment on pull request #4458: [IOTDB-1673] CLI refactor and upgrade to JLine3

Posted by GitBox <gi...@apache.org>.

coveralls edited a comment on pull request #4458:
URL: https://github.com/apache/iotdb/pull/4458#issuecomment-977528356


   
   [![Coverage Status](https://coveralls.io/builds/44532088/badge)](https://coveralls.io/builds/44532088)
   
   Coverage decreased (-0.008%) to 67.232% when pulling **29104456fdde56c4e4759cc909d94b64bc0ce9d0 on cornmonster:feature/cli_refactor** into **14505c175a8c1e98535757027f36210b07de213c on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] cornmonster commented on a change in pull request #4458: [IOTDB-1673] CLI refactor

Posted by GitBox <gi...@apache.org>.

cornmonster commented on a change in pull request #4458:
URL: https://github.com/apache/iotdb/pull/4458#discussion_r755889493



##########
File path: cli/pom.xml
##########
@@ -66,9 +66,18 @@
             <version>0.9.2</version>
         </dependency>
         <dependency>
-            <groupId>jline</groupId>
+            <groupId>org.jline</groupId>
             <artifactId>jline</artifactId>
         </dependency>
+        <dependency>
+            <groupId>net.java.dev.jna</groupId>
+            <artifactId>jna</artifactId>
+        </dependency>

Review comment:
       To access the JVM's main terminal under the Windows system for Jline3 to provide advanced features.
   
   Here's Jline3's document about JNA:
   ![image](https://user-images.githubusercontent.com/20107543/143218637-57dfc92b-5301-4967-93da-11a7e1ea8c65.png)
   
   You may also access the page via this link: https://github.com/jline/jline3
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] cornmonster commented on pull request #4458: [IOTDB-1673] CLI refactor

Posted by GitBox <gi...@apache.org>.

cornmonster commented on pull request #4458:
URL: https://github.com/apache/iotdb/pull/4458#issuecomment-978722644


   > Hi, would you like to update the version in LICENSE-binary?
   > https://github.com/apache/iotdb/blob/master/LICENSE-binary
   
   No problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] HTHou commented on pull request #4458: [IOTDB-1673] CLI refactor

Posted by GitBox <gi...@apache.org>.

HTHou commented on pull request #4458:
URL: https://github.com/apache/iotdb/pull/4458#issuecomment-977822233


   Hi, would you like to update the version in LICENSE-binary?
   https://github.com/apache/iotdb/blob/master/LICENSE-binary


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] cornmonster commented on a change in pull request #4458: [IOTDB-1673] CLI refactor

Posted by GitBox <gi...@apache.org>.

cornmonster commented on a change in pull request #4458:
URL: https://github.com/apache/iotdb/pull/4458#discussion_r755889493



##########
File path: cli/pom.xml
##########
@@ -66,9 +66,18 @@
             <version>0.9.2</version>
         </dependency>
         <dependency>
-            <groupId>jline</groupId>
+            <groupId>org.jline</groupId>
             <artifactId>jline</artifactId>
         </dependency>
+        <dependency>
+            <groupId>net.java.dev.jna</groupId>
+            <artifactId>jna</artifactId>
+        </dependency>

Review comment:
       To access the JVM's main terminal under the Windows system for Jline3 to provide advanced features.
   
   Please see:
   ![image](https://user-images.githubusercontent.com/20107543/143218637-57dfc92b-5301-4967-93da-11a7e1ea8c65.png)
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] HTHou merged pull request #4458: [IOTDB-1673] CLI refactor and upgrade to JLine3

Posted by GitBox <gi...@apache.org>.

HTHou merged pull request #4458:
URL: https://github.com/apache/iotdb/pull/4458


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] HTHou commented on a change in pull request #4458: [IOTDB-1673] CLI refactor

Posted by GitBox <gi...@apache.org>.

HTHou commented on a change in pull request #4458:
URL: https://github.com/apache/iotdb/pull/4458#discussion_r755832030



##########
File path: cli/pom.xml
##########
@@ -66,9 +66,18 @@
             <version>0.9.2</version>
         </dependency>
         <dependency>
-            <groupId>jline</groupId>
+            <groupId>org.jline</groupId>
             <artifactId>jline</artifactId>
         </dependency>
+        <dependency>
+            <groupId>net.java.dev.jna</groupId>
+            <artifactId>jna</artifactId>
+        </dependency>

Review comment:
       Hi, what is this dependency use for? 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] coveralls commented on pull request #4458: [IOTDB-1673] CLI refactor

Posted by GitBox <gi...@apache.org>.

coveralls commented on pull request #4458:
URL: https://github.com/apache/iotdb/pull/4458#issuecomment-977528356


   
   [![Coverage Status](https://coveralls.io/builds/44503099/badge)](https://coveralls.io/builds/44503099)
   
   Coverage increased (+0.03%) to 67.274% when pulling **ed5058c35f193e6382faab8e39248301b6f989d1 on cornmonster:feature/cli_refactor** into **14505c175a8c1e98535757027f36210b07de213c on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org