You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@drill.apache.org by GitBox <gi...@apache.org> on 2022/07/05 03:23:29 UTC

[GitHub] [drill] kingswanwho opened a new pull request, #2584: [BACKPORT-TO-STABLE] Bugfix Release 1.20.2

kingswanwho opened a new pull request, #2584:
URL: https://github.com/apache/drill/pull/2584

   # [BACKPORT-TO-STABLE] Bugfix Release 1.20.2 
   
   ## Description
   
   Merged several backport-to-stable commits for new bugfix release 1.20.2, which includes:
   
   * https://github.com/apache/drill/pull/2577
   * https://github.com/apache/drill/pull/2572
   * https://github.com/apache/drill/pull/2565
   * https://github.com/apache/drill/pull/2564
   
   Commit with backport-to-stable tag https://github.com/apache/drill/pull/2575, is based on commit https://github.com/apache/drill/pull/2516, which is a new feature after release 1.20. So excluded from this PR.
   
   ## Documentation
   None.
   
   ## Testing
   UT


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] kingswanwho commented on pull request #2584: [BACKPORT-TO-STABLE] Bugfix Release 1.20.2

Posted by GitBox <gi...@apache.org>.
kingswanwho commented on PR #2584:
URL: https://github.com/apache/drill/pull/2584#issuecomment-1174612488

   > > I found that [8c1f13c](https://github.com/apache/drill/commit/8c1f13c0f68826abeea0a83ab07cbd763790553b) also bases on #2516, so I will exclude this commit either.
   > 
   > That commit has already been cherry picked into the 1.20 branch.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] kingswanwho commented on pull request #2584: [BACKPORT-TO-STABLE] Bugfix Release 1.20.2

Posted by GitBox <gi...@apache.org>.
kingswanwho commented on PR #2584:
URL: https://github.com/apache/drill/pull/2584#issuecomment-1174632667

   > #2516
   
   Hi James, #2516 introduces the new Authmode, and TestJdbcPluginWithMSSQL.java uses this new feature, maybe we could backport this feature to branch 1.20, so the compile should not have this problem.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] jnturton merged pull request #2584: [BACKPORT-TO-STABLE] Bugfix Release 1.20.2

Posted by GitBox <gi...@apache.org>.
jnturton merged PR #2584:
URL: https://github.com/apache/drill/pull/2584


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] kingswanwho commented on pull request #2584: [BACKPORT-TO-STABLE] Bugfix Release 1.20.2

Posted by GitBox <gi...@apache.org>.
kingswanwho commented on PR #2584:
URL: https://github.com/apache/drill/pull/2584#issuecomment-1174602941

   > > I found that [8c1f13c](https://github.com/apache/drill/commit/8c1f13c0f68826abeea0a83ab07cbd763790553b) also bases on #2516, so I will exclude this commit either.
   > 
   > That commit has already been cherry picked into the 1.20 branch.
   
   But 1.20 branch compile failed on my local, it's weird.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] jnturton commented on pull request #2584: [BACKPORT-TO-STABLE] Bugfix Release 1.20.2

Posted by GitBox <gi...@apache.org>.
jnturton commented on PR #2584:
URL: https://github.com/apache/drill/pull/2584#issuecomment-1174759621

   Okay, I did indeed not do proper job of backporting DRILL-8227 / #2551. Please may you add a new commit to your PR with a commit message like
   
   ```
   DRILL-8227: JConnect and jTDS JDBC drivers do not implement Connection::getSchema
   
   Fix build errors in the original backport attempt (aa5341df6).
   ```
   
   which removes AuthMode references from TestJdbcPluginWithMSSQL as follows.
   
   ```
   diff --git a/contrib/storage-jdbc/src/test/java/org/apache/drill/exec/store/jdbc/TestJdbcPluginWithMSSQL.java b/contrib/storage-jdbc/src/test/java/org/apache/drill/exec/store/jdbc/TestJdbcPluginWithMSSQL.java
   index 68c687126..5b7b5d892 100644
   --- a/contrib/storage-jdbc/src/test/java/org/apache/drill/exec/store/jdbc/TestJdbcPluginWithMSSQL.java
   +++ b/contrib/storage-jdbc/src/test/java/org/apache/drill/exec/store/jdbc/TestJdbcPluginWithMSSQL.java
   @@ -19,7 +19,6 @@ package org.apache.drill.exec.store.jdbc;
    
    import org.apache.drill.categories.JdbcStorageTest;
    import org.apache.drill.common.logical.security.PlainCredentialsProvider;
   -import org.apache.drill.common.logical.StoragePluginConfig.AuthMode;
    import org.apache.drill.common.types.TypeProtos.MinorType;
    import org.apache.drill.exec.physical.rowSet.DirectRowSet;
    import org.apache.drill.exec.physical.rowSet.RowSet;
   @@ -86,7 +85,6 @@ public class TestJdbcPluginWithMSSQL extends ClusterTest {
          false,
          sourceParms,
          credentialsProvider,
   -      AuthMode.SHARED_USER.name(),
          100000
        );
        jdbcStorageConfig.setEnabled(true);
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] kingswanwho commented on pull request #2584: [BACKPORT-TO-STABLE] Bugfix Release 1.20.2

Posted by GitBox <gi...@apache.org>.
kingswanwho commented on PR #2584:
URL: https://github.com/apache/drill/pull/2584#issuecomment-1174814533

   tra
   
   > Okay, I did indeed not do a proper job of backporting DRILL-8227 / #2551. Please may you add a new commit to your PR with a commit message like
   > 
   > ```
   > DRILL-8227: JConnect and jTDS JDBC drivers do not implement Connection::getSchema
   > 
   > Fix build errors in the original backport attempt (aa5341df6).
   > ```
   > 
   > which removes AuthMode references from TestJdbcPluginWithMSSQL as follows.
   > 
   > ```
   > diff --git a/contrib/storage-jdbc/src/test/java/org/apache/drill/exec/store/jdbc/TestJdbcPluginWithMSSQL.java b/contrib/storage-jdbc/src/test/java/org/apache/drill/exec/store/jdbc/TestJdbcPluginWithMSSQL.java
   > index 68c687126..5b7b5d892 100644
   > --- a/contrib/storage-jdbc/src/test/java/org/apache/drill/exec/store/jdbc/TestJdbcPluginWithMSSQL.java
   > +++ b/contrib/storage-jdbc/src/test/java/org/apache/drill/exec/store/jdbc/TestJdbcPluginWithMSSQL.java
   > @@ -19,7 +19,6 @@ package org.apache.drill.exec.store.jdbc;
   >  
   >  import org.apache.drill.categories.JdbcStorageTest;
   >  import org.apache.drill.common.logical.security.PlainCredentialsProvider;
   > -import org.apache.drill.common.logical.StoragePluginConfig.AuthMode;
   >  import org.apache.drill.common.types.TypeProtos.MinorType;
   >  import org.apache.drill.exec.physical.rowSet.DirectRowSet;
   >  import org.apache.drill.exec.physical.rowSet.RowSet;
   > @@ -86,7 +85,6 @@ public class TestJdbcPluginWithMSSQL extends ClusterTest {
   >        false,
   >        sourceParms,
   >        credentialsProvider,
   > -      AuthMode.SHARED_USER.name(),
   >        100000
   >      );
   >      jdbcStorageConfig.setEnabled(true);
   > ```
   
   Hi, James Have submitted the commit as you suggested. Local build passed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] jnturton commented on pull request #2584: [BACKPORT-TO-STABLE] Bugfix Release 1.20.2

Posted by GitBox <gi...@apache.org>.
jnturton commented on PR #2584:
URL: https://github.com/apache/drill/pull/2584#issuecomment-1174600134

   > I found that [8c1f13c](https://github.com/apache/drill/commit/8c1f13c0f68826abeea0a83ab07cbd763790553b) also bases on #2516, so I will exclude this commit either.
   
   That commit has already been cherry picked into the 1.20 branch. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] kingswanwho closed pull request #2584: [BACKPORT-TO-STABLE] Bugfix Release 1.20.2

Posted by GitBox <gi...@apache.org>.
kingswanwho closed pull request #2584: [BACKPORT-TO-STABLE] Bugfix Release 1.20.2 
URL: https://github.com/apache/drill/pull/2584


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] jnturton commented on pull request #2584: [BACKPORT-TO-STABLE] Bugfix Release 1.20.2

Posted by GitBox <gi...@apache.org>.
jnturton commented on PR #2584:
URL: https://github.com/apache/drill/pull/2584#issuecomment-1174696968

   > > #2516
   > 
   > Hi James, #2516 introduces the new Authmode, and TestJdbcPluginWithMSSQL.java uses this new feature, maybe we could backport this feature to branch 1.20, so the compile should not have the problem.
   
   The auth mode work is definitely not something we can backport, but the build looks fine. Let's pause this PR for a moment because the unit test failure you're getting from TestSpnegoAuthentication is resolved in a couple of open PRs (#2582, #2583), both of which are backportable. So once one of them is merged you can backport that and the 1.20 branch should be in good shape.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [drill] kingswanwho commented on pull request #2584: [BACKPORT-TO-STABLE] Bugfix Release 1.20.2

Posted by GitBox <gi...@apache.org>.
kingswanwho commented on PR #2584:
URL: https://github.com/apache/drill/pull/2584#issuecomment-1174597327

   I found that https://github.com/apache/drill/commit/8c1f13c0f68826abeea0a83ab07cbd763790553b also bases on https://github.com/apache/drill/pull/2516, so I will exclude this commit either.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@drill.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org