You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@opendal.apache.org by "ZutJoe (via GitHub)" <gi...@apache.org> on 2023/11/23 10:44:33 UTC
[PR] feat: disable `ftp` for python and java binding [incubator-opendal]
ZutJoe opened a new pull request, #3659:
URL: https://github.com/apache/incubator-opendal/pull/3659
resolve #3650
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: disable `ftp` for python and java binding [incubator-opendal]
Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo merged PR #3659:
URL: https://github.com/apache/incubator-opendal/pull/3659
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: disable `ftp` for python and java binding [incubator-opendal]
Posted by "suyanhanx (via GitHub)" <gi...@apache.org>.
suyanhanx commented on code in PR #3659:
URL: https://github.com/apache/incubator-opendal/pull/3659#discussion_r1403436117
##########
bindings/java/upgrade.md:
##########
@@ -19,3 +19,10 @@ Operator.of(scheme, config);
```
Now, there is no public constructor for operators, but only factory methods. In this way, the APIs are free to do arbitrary verifications and preparations before constructing operators.
+
+
+# Unreleased
+
+## Breaking change
+
+Because of [a TLS lib issue](https://github.com/apache/incubator-opendal/issues/3650), we temporarily disable the `services-ftp` feature.
Review Comment:
Please put the unreleased part at the top of the file.
##########
bindings/python/upgrade.md:
##########
@@ -45,4 +45,10 @@ We remove the old error classes and provide a couple of Exception based class fo
11. `opendal.exceptions.ConditionNotMatch` is added.
12. `opendal.exceptions.ContentTruncated` is added.
13. `opendal.exceptions.ContentIncomplete` is added.
-14. `opendal.exceptions.InvalidInput` is added.
\ No newline at end of file
+14. `opendal.exceptions.InvalidInput` is added.
+
+# Unreleased
+
+## Breaking change
+
+Because of [a TLS lib issue](https://github.com/apache/incubator-opendal/issues/3650), we temporarily disable the `services-ftp` feature.
Review Comment:
Same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: disable `ftp` for python and java binding [incubator-opendal]
Posted by "ZutJoe (via GitHub)" <gi...@apache.org>.
ZutJoe commented on code in PR #3659:
URL: https://github.com/apache/incubator-opendal/pull/3659#discussion_r1403425872
##########
bindings/python/upgrade.md:
##########
@@ -45,4 +45,10 @@ We remove the old error classes and provide a couple of Exception based class fo
11. `opendal.exceptions.ConditionNotMatch` is added.
12. `opendal.exceptions.ContentTruncated` is added.
13. `opendal.exceptions.ContentIncomplete` is added.
-14. `opendal.exceptions.InvalidInput` is added.
\ No newline at end of file
+14. `opendal.exceptions.InvalidInput` is added.
+
+# Unreleased
+
+## Breaking change
+
+Because of [a TLS lib issue](https://github.com/apache/incubator-opendal/issues/3650), we temporarily disable the `services-ftp`.
Review Comment:
Okay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: disable `ftp` for python and java binding [incubator-opendal]
Posted by "ZutJoe (via GitHub)" <gi...@apache.org>.
ZutJoe commented on code in PR #3659:
URL: https://github.com/apache/incubator-opendal/pull/3659#discussion_r1403448029
##########
bindings/python/upgrade.md:
##########
@@ -45,4 +45,10 @@ We remove the old error classes and provide a couple of Exception based class fo
11. `opendal.exceptions.ConditionNotMatch` is added.
12. `opendal.exceptions.ContentTruncated` is added.
13. `opendal.exceptions.ContentIncomplete` is added.
-14. `opendal.exceptions.InvalidInput` is added.
\ No newline at end of file
+14. `opendal.exceptions.InvalidInput` is added.
+
+# Unreleased
+
+## Breaking change
+
+Because of [a TLS lib issue](https://github.com/apache/incubator-opendal/issues/3650), we temporarily disable the `services-ftp` feature.
Review Comment:
Okay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat: disable `ftp` for python and java binding [incubator-opendal]
Posted by "messense (via GitHub)" <gi...@apache.org>.
messense commented on code in PR #3659:
URL: https://github.com/apache/incubator-opendal/pull/3659#discussion_r1403357819
##########
bindings/java/upgrade.md:
##########
@@ -19,3 +19,10 @@ Operator.of(scheme, config);
```
Now, there is no public constructor for operators, but only factory methods. In this way, the APIs are free to do arbitrary verifications and preparations before constructing operators.
+
+
+# Unreleased
+
+## Breaking change
+
+Because of [a TLS lib issue](https://github.com/apache/incubator-opendal/issues/3650), we temporarily disable the `services-ftp`.
Review Comment:
```suggestion
Because of [a TLS lib issue](https://github.com/apache/incubator-opendal/issues/3650), we temporarily disable the `services-ftp` feature.
```
##########
bindings/python/upgrade.md:
##########
@@ -45,4 +45,10 @@ We remove the old error classes and provide a couple of Exception based class fo
11. `opendal.exceptions.ConditionNotMatch` is added.
12. `opendal.exceptions.ContentTruncated` is added.
13. `opendal.exceptions.ContentIncomplete` is added.
-14. `opendal.exceptions.InvalidInput` is added.
\ No newline at end of file
+14. `opendal.exceptions.InvalidInput` is added.
+
+# Unreleased
+
+## Breaking change
+
+Because of [a TLS lib issue](https://github.com/apache/incubator-opendal/issues/3650), we temporarily disable the `services-ftp`.
Review Comment:
```suggestion
Because of [a TLS lib issue](https://github.com/apache/incubator-opendal/issues/3650), we temporarily disable the `services-ftp` feature.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@opendal.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org