[GitHub] [tvm] tqchen commented on a change in pull request #7456: [QNN][TFLite] TFLite rounding mode support

[GitBox <gi...@apache.org>]

tqchen commented on a change in pull request #7456:
URL: https://github.com/apache/tvm/pull/7456#discussion_r577665517



##########
File path: include/tvm/tir/analysis.h
##########
@@ -56,6 +57,55 @@ struct ExprDeepEqual {
   TVM_DLL bool operator()(const PrimExpr& lhs, const PrimExpr& rhs) const;
 };
 
+#define PLUS_ONE(OP) \
+  void VisitExpr_(const OP* op) final { num_symbols_++; }
+
+#define PLUS_ONE_BINARY(OP)             \
+  void VisitExpr_(const OP* op) final { \
+    num_symbols_++;                     \
+    VisitExpr(op->a);                   \
+    VisitExpr(op->b);                   \
+  }
+
+/*!
+ * \brief Calculate the expresion complexity based on number of symbols it contains.
+ */
+class ExprComplexity : public ExprVisitor {

Review comment:
       Consider move to src/tir/analysis/ and leave a function interface here




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org