You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@brpc.apache.org by GitBox <gi...@apache.org> on 2022/10/31 02:33:18 UTC

[GitHub] [incubator-brpc-website] wwbmmm commented on a diff in pull request #105: try to fix external resources stackpath.bootstrapcdn.com

wwbmmm commented on code in PR #105:
URL: https://github.com/apache/incubator-brpc-website/pull/105#discussion_r1008985463


##########
themes/docsy/assets/vendor/bootstrap/_config.yml:
##########
@@ -49,13 +49,13 @@ download:
 
 cdn:
   # See https://www.srihash.org for info on how to generate the hashes
-  css:              "https://stackpath.bootstrapcdn.com/bootstrap/4.1.3/css/bootstrap.min.css"
+  css:              "https://github.com/apache/incubator-brpc-website/tree/master/themes/docsy/static/css/bootstrap.min.css"

Review Comment:
   这个css文件在编译时应该会被打包到站点的目录里，直接引用本站的路径就可以，不需要加域名



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@brpc.apache.org
For additional commands, e-mail: dev-help@brpc.apache.org