You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/07/22 05:56:45 UTC

[GitHub] [spark] dongjoon-hyun commented on pull request #28898: [SPARK-32059][SQL] Allow nested schema pruning thru window/sort plans

dongjoon-hyun commented on pull request #28898:
URL: https://github.com/apache/spark/pull/28898#issuecomment-662257917


   @frankyin-factual . Thank you for updating. In general, it's a nice improvement contribution.
   - For the test cases, you may have a different idea. 
   - For the `unapply` pattern stuff, I believe we need more comment on that code path because it looks suspicious logically.
   
   I'll review tomorrow again with a fresh eye and build and test more by myself. That helps me review.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org