You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by is...@cocoondev.org on 2005/05/26 17:49:55 UTC

[JIRA] Created: (FOR-506) Do not hard-code site-visible message strings in skin files

Message:

  A new issue has been created in JIRA.

---------------------------------------------------------------------
View the issue:
  http://issues.cocoondev.org//browse/FOR-506

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: FOR-506
    Summary: Do not hard-code site-visible message strings in skin files
       Type: Improvement

     Status: Unassigned
   Priority: Minor

    Project: Forrest
 Components: 
             Skins (general issues)
   Versions:
             0.7-dev

   Assignee: 
   Reporter: Pedro I. Sanchez

    Created: Thu, 26 May 2005 10:49 AM
    Updated: Thu, 26 May 2005 10:49 AM
Environment: N/A

Description:
Text strings like "Copyright", "Published", and "Search" are hardcoded into skin files like site2xhtml.xsl. When creating web sites in languages other than English the web developer is forced to create local versions of these skin files with the appropriated translations.

Instead, the DTD for the skinconf.xml should be improved to allow these translations to be specified in this file. This would make Forrest much easier to use.




---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.cocoondev.org//secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira

[JIRA] Commented: (FOR-506) Do not hard-code site-visible message strings in skin files

Posted by is...@cocoondev.org.
The following comment has been added to this issue:

     Author: Ross Gardler
    Created: Thu, 26 May 2005 2:48 PM
       Body:
My question was to it was to Cyriaque who said your proposal was not sufficient. I was asking why and adding details to the proposal.

But since you ask for more info here we go (if this becomes a desgn discussion we should move it to the dev list and then place a summary here).

"a) How do you enable the <i18n ..> </i18n> thing to work? I just put your code in my web site and Forrest complains with..."

My example is intended to be a suggestion for how the DTD could be extended to support what you are requesting. It doesn't exist yet.

"b) lang="en", what does it mean?"

Forrest has some "in development" i18n features, this would be one of them. I'm not sure exactly how it works, but somehow Forrest must be told which language to server. This value would be used in the skinning process in order to select the correct language tokens.

"2. What about the non-tokenized strings like "Search"?"

Currently none of the strings are tokenised. If we adopt this solution then we will need to tokenise them all. This is open source - can you help us since this is your itch?

If you want to tackle this discuss it with us on the dev list, we can help by pointing you in the right direction. Otherwise you'll have to wait until a dev finds the time and inclination to implement this, or another solution.
---------------------------------------------------------------------
View this comment:
  http://issues.cocoondev.org//browse/FOR-506?page=comments#action_12434

---------------------------------------------------------------------
View the issue:
  http://issues.cocoondev.org//browse/FOR-506

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: FOR-506
    Summary: Do not hard-code site-visible message strings in skin files
       Type: Improvement

     Status: Unassigned
   Priority: Minor

    Project: Forrest
 Components: 
             Skins (general issues)
   Versions:
             0.7-dev

   Assignee: 
   Reporter: Pedro I. Sanchez

    Created: Thu, 26 May 2005 10:49 AM
    Updated: Thu, 26 May 2005 2:48 PM
Environment: N/A

Description:
Text strings like "Copyright", "Published", and "Search" are hardcoded into skin files like site2xhtml.xsl. When creating web sites in languages other than English the web developer is forced to create local versions of these skin files with the appropriated translations.

Instead, the DTD for the skinconf.xml should be improved to allow these translations to be specified in this file. This would make Forrest much easier to use.




---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.cocoondev.org//secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira

[JIRA] Commented: (FOR-506) Do not hard-code site-visible message strings in skin files

Posted by is...@cocoondev.org.
The following comment has been added to this issue:

     Author: Pedro I. Sanchez
    Created: Thu, 26 May 2005 2:26 PM
       Body:
Couple of comments:

1. It could work, but for me to test it I would like to get clarification on two things:

a) How do you enable the <i18n ..> </i18n> thing to work? I just put your code in my web site and Forrest complains with 

skinconf.xml:369:9: Element type "i18n" must be declared.
skinconf.xml:370:50: Element type "token" must be declared.

b) lang="en", what does it mean? If "en" refers to the system language in the host where the web developer is working (the locale setting) then this doesn't work. I am developing an all-Spanish web site while working in an all english host environment.

2. What about the non-tokenized strings like "Search"?


---------------------------------------------------------------------
View this comment:
  http://issues.cocoondev.org//browse/FOR-506?page=comments#action_12433

---------------------------------------------------------------------
View the issue:
  http://issues.cocoondev.org//browse/FOR-506

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: FOR-506
    Summary: Do not hard-code site-visible message strings in skin files
       Type: Improvement

     Status: Unassigned
   Priority: Minor

    Project: Forrest
 Components: 
             Skins (general issues)
   Versions:
             0.7-dev

   Assignee: 
   Reporter: Pedro I. Sanchez

    Created: Thu, 26 May 2005 10:49 AM
    Updated: Thu, 26 May 2005 2:26 PM
Environment: N/A

Description:
Text strings like "Copyright", "Published", and "Search" are hardcoded into skin files like site2xhtml.xsl. When creating web sites in languages other than English the web developer is forced to create local versions of these skin files with the appropriated translations.

Instead, the DTD for the skinconf.xml should be improved to allow these translations to be specified in this file. This would make Forrest much easier to use.




---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.cocoondev.org//secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira

[JIRA] Commented: (FOR-506) Do not hard-code site-visible message strings in skin files

Posted by is...@cocoondev.org.
The following comment has been added to this issue:

     Author: Pedro I. Sanchez
    Created: Fri, 27 May 2005 8:54 AM
       Body:
Sounds good. I will subscribe to the dev list and will open a new thread on this topic. With your guidance I can put some time helping to implement something. I'm sure I will learn quite a bit in doing so.


---------------------------------------------------------------------
View this comment:
  http://issues.cocoondev.org//browse/FOR-506?page=comments#action_12438

---------------------------------------------------------------------
View the issue:
  http://issues.cocoondev.org//browse/FOR-506

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: FOR-506
    Summary: Do not hard-code site-visible message strings in skin files
       Type: Improvement

     Status: Unassigned
   Priority: Minor

    Project: Forrest
 Components: 
             Skins (general issues)
   Versions:
             0.7-dev

   Assignee: 
   Reporter: Pedro I. Sanchez

    Created: Thu, 26 May 2005 10:49 AM
    Updated: Fri, 27 May 2005 8:54 AM
Environment: N/A

Description:
Text strings like "Copyright", "Published", and "Search" are hardcoded into skin files like site2xhtml.xsl. When creating web sites in languages other than English the web developer is forced to create local versions of these skin files with the appropriated translations.

Instead, the DTD for the skinconf.xml should be improved to allow these translations to be specified in this file. This would make Forrest much easier to use.




---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.cocoondev.org//secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira

[JIRA] Commented: (FOR-506) Do not hard-code site-visible message strings in skin files

Posted by is...@cocoondev.org.
The following comment has been added to this issue:

     Author: Cyriaque Dupoirieux
    Created: Thu, 26 May 2005 11:12 AM
       Body:
Excellent, but I don't think it's a minor problem.
My own skin - originally based on pelt - is now far from the original one generally for translation reason.
The ProjectInfo plugin has now the same limits and I also have my own copy of it...

The configuration management begins to be complex for me when a file changes...
---------------------------------------------------------------------
View this comment:
  http://issues.cocoondev.org//browse/FOR-506?page=comments#action_12430

---------------------------------------------------------------------
View the issue:
  http://issues.cocoondev.org//browse/FOR-506

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: FOR-506
    Summary: Do not hard-code site-visible message strings in skin files
       Type: Improvement

     Status: Unassigned
   Priority: Minor

    Project: Forrest
 Components: 
             Skins (general issues)
   Versions:
             0.7-dev

   Assignee: 
   Reporter: Pedro I. Sanchez

    Created: Thu, 26 May 2005 10:49 AM
    Updated: Thu, 26 May 2005 11:12 AM
Environment: N/A

Description:
Text strings like "Copyright", "Published", and "Search" are hardcoded into skin files like site2xhtml.xsl. When creating web sites in languages other than English the web developer is forced to create local versions of these skin files with the appropriated translations.

Instead, the DTD for the skinconf.xml should be improved to allow these translations to be specified in this file. This would make Forrest much easier to use.




---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.cocoondev.org//secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira

[JIRA] Commented: (FOR-506) Do not hard-code site-visible message strings in skin files

Posted by is...@cocoondev.org.
The following comment has been added to this issue:

     Author: Ross Gardler
    Created: Thu, 26 May 2005 11:50 AM
       Body:
Can you describe what you think the problem would be with this propsed solution of extending skinconf.xml?

For example:

<i18n lang="en">
  <token name="lastPublished" value="Last Published"/>
  <token name="copyright" value="Copyright"/>
</i18n>
<i18n lang="??">
  <token name="lastPublished" value="???????"/>
  <token name="copyright" value="???????"/>
</i18n>

This schema allows any token to be added, so customisation of skins would not be a problem.
  
---------------------------------------------------------------------
View this comment:
  http://issues.cocoondev.org//browse/FOR-506?page=comments#action_12431

---------------------------------------------------------------------
View the issue:
  http://issues.cocoondev.org//browse/FOR-506

Here is an overview of the issue:
---------------------------------------------------------------------
        Key: FOR-506
    Summary: Do not hard-code site-visible message strings in skin files
       Type: Improvement

     Status: Unassigned
   Priority: Minor

    Project: Forrest
 Components: 
             Skins (general issues)
   Versions:
             0.7-dev

   Assignee: 
   Reporter: Pedro I. Sanchez

    Created: Thu, 26 May 2005 10:49 AM
    Updated: Thu, 26 May 2005 11:50 AM
Environment: N/A

Description:
Text strings like "Copyright", "Published", and "Search" are hardcoded into skin files like site2xhtml.xsl. When creating web sites in languages other than English the web developer is forced to create local versions of these skin files with the appropriated translations.

Instead, the DTD for the skinconf.xml should be improved to allow these translations to be specified in this file. This would make Forrest much easier to use.




---------------------------------------------------------------------
JIRA INFORMATION:
This message is automatically generated by JIRA.

If you think it was sent incorrectly contact one of the administrators:
   http://issues.cocoondev.org//secure/Administrators.jspa

If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira