You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/20 16:03:16 UTC
[GitHub] [arrow-datafusion] andygrove opened a new pull request, #2290: Move FileType enum from sql module to logical_plan module
andygrove opened a new pull request, #2290:
URL: https://github.com/apache/arrow-datafusion/pull/2290
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Closes https://github.com/apache/arrow-datafusion/issues/2288
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
This is a step towards being able to move the logical plan to the expr crate.
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
Moves `FileType` from sql module to logical_plan module.
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
No
<!--
If there are any breaking changes to public APIs, please add the `api change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #2290: Move FileType enum from sql module to logical_plan module
Posted by GitBox <gi...@apache.org>.
alamb merged PR #2290:
URL: https://github.com/apache/arrow-datafusion/pull/2290
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #2290: Move FileType enum from sql module to logical_plan module
Posted by GitBox <gi...@apache.org>.
alamb commented on code in PR #2290:
URL: https://github.com/apache/arrow-datafusion/pull/2290#discussion_r854571499
##########
datafusion/core/src/logical_plan/plan.rs:
##########
@@ -24,7 +24,6 @@ use crate::datasource::datasource::TableProviderFilterPushDown;
use crate::datasource::TableProvider;
use crate::error::DataFusionError;
use crate::logical_plan::dfschema::DFSchemaRef;
-use crate::sql::parser::FileType;
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on pull request #2290: Move FileType enum from sql module to logical_plan module
Posted by GitBox <gi...@apache.org>.
alamb commented on PR #2290:
URL: https://github.com/apache/arrow-datafusion/pull/2290#issuecomment-1104475009
Merging as this one seems uncontroversial
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org