[jira] [Updated] (SOLR-2663) Refactor FieldTypePluginLoader out of IndexSchema

["Hoss Man (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-2663?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Hoss Man updated SOLR-2663:
---------------------------

    Attachment: SOLR_2663.patch

patch that refactors a big chunkc of IndexSchema.readSchema into a new public FieldTypePluginLoader.

This patch also adds a new public getDefaultLuceneMatchVersion() to IndexSchema (which seems like it should have been added a while ago) and converts the existing private IndexSchema.readSimilarity method into a package protected static method since it's used both for hte global default and for per field similarity (i thought about making it public, but it wasn't entirely obvious that it's something we really want to advertise)


> Refactor FieldTypePluginLoader out of IndexSchema
> -------------------------------------------------
>
>                 Key: SOLR-2663
>                 URL: https://issues.apache.org/jira/browse/SOLR-2663
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Hoss Man
>            Assignee: Hoss Man
>         Attachments: SOLR_2663.patch
>
>
> I have a use case where i'd like to be able to programmaticly "test" if a (single) arbitrary FieldType configuration is valid, but this is currently impossibly because the code to parse/init FieldTypes is buried deep inside IndexSchema.readSchema using anonymous inner-subclasses of AbstractPluginLoader.
> I'd like to refactor this out into a concrete public class.  Regardless of my usecase, i think this is a good idea in general since it makes IndexSchema a lot easier to read/maintain and helps make it more obvious exactly what info is being used when initializing the FieldTypes+Analyzers

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org