[GitHub] [airflow] jedcunningham commented on a diff in pull request #31625: Add missing waitForMigrations for workers

["jedcunningham (via GitHub)" <gi...@apache.org>]

jedcunningham commented on code in PR #31625:
URL: https://github.com/apache/airflow/pull/31625#discussion_r1212439396


##########
tests/charts/airflow_core/test_worker.py:
##########
@@ -82,6 +82,18 @@ def test_should_add_extra_containers(self):
             "image": "test-registry/test-repo:test-tag",
         } == jmespath.search("spec.template.spec.containers[-1]", docs[0])
 
+    def test_disable_wait_for_migration(self):
+        docs = render_chart(
+            values={
+                "workers": {
+                    "waitForMigrations": {"enabled": False},
+                },
+            },
+            show_only=["templates/workers/worker-deployment.yaml"],
+        )
+        actual = jmespath.search("spec.template.spec.initContainers", docs[0])
+        assert actual is None

Review Comment:
   Let's just make this specific one less brittle, then open a separate PR for the others.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org