You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by chrisz <gi...@git.apache.org> on 2014/09/10 15:47:51 UTC
[GitHub] incubator-storm pull request: STORM-493: Workers inherit storm.con...
GitHub user chrisz opened a pull request:
https://github.com/apache/incubator-storm/pull/252
STORM-493: Workers inherit storm.conf.file/storm.options properties of their supervisor
Without this fix, if we override some configuration parameters on the command line (using storm -c "param=value") when we launch the supervisor, workers don't inherit them.
There is a similar problem with configuration file name. If we specify it on the command line, workers don't inherit it and search the default "storm.yaml" file in the classpath.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chrisz/incubator-storm STORM-493
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-storm/pull/252.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #252
----
commit 4a7e634354df85f9ce52338a33e1e5fc1472f406
Author: Christophe Carré <ch...@ymail.com>
Date: 2014-09-10T13:32:53Z
STORM-493: Workers inherit storm.conf.file/storm.options properties of their supervisor
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-493: Workers inherit storm.con...
Posted by chrisz <gi...@git.apache.org>.
Github user chrisz commented on the pull request:
https://github.com/apache/incubator-storm/pull/252#issuecomment-55294806
I have some difficulties to have a working environment to execute unit tests of Storm: there are some timeout during tests (even before my fix) and I don't know what is bad with ma machine.
I fixed unit tests related to my change. I tried to add some tests but I am not comfortable with clojure...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-storm pull request: STORM-493: Workers inherit storm.con...
Posted by Parth-Brahmbhatt <gi...@git.apache.org>.
Github user Parth-Brahmbhatt commented on the pull request:
https://github.com/apache/incubator-storm/pull/252#issuecomment-55157211
Can you modify/add a test to validate this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---