[GitHub] [pinot] walterddr commented on a diff in pull request #10792: Add required JSON annotation in H3IndexResolution

["walterddr (via GitHub)" <gi...@apache.org>]

walterddr commented on code in PR #10792:
URL: https://github.com/apache/pinot/pull/10792#discussion_r1205737889


##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/reader/H3IndexResolution.java:
##########
@@ -91,4 +94,11 @@ public boolean equals(Object o) {
   public int hashCode() {
     return Objects.hash(_resolutions);
   }
+
+  public static class ToIntListConverted extends StdConverter<H3IndexResolution, List<Integer>> {

Review Comment:
   was wondering if we can do 
   - serialize just the short format and not to List<Integer> serialization?
   - still keep the JSON creator but also annotate the short constructor as JSON create?
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org