You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Ashutosh Kelkar <as...@clogeny.com> on 2014/07/22 09:05:17 UTC
Review Request 23793: CLOUDSTACK-7137: Resolving cleanup issue in
test_escalations_securitygroups.py
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23793/
-----------------------------------------------------------
Review request for cloudstack and Girish Shilamkar.
Bugs: CLOUDSTACK-7137
https://issues.apache.org/jira/browse/CLOUDSTACK-7137
Repository: cloudstack-git
Description
-------
Resolved the cleanup issue. The security group was not removed from cleanup list after deleting it. So it failed to find the security group in cleanup operation.
Also, removed the unnecessary imports.
Diffs
-----
test/integration/component/test_escalations_securitygroups.py 8934088
Diff: https://reviews.apache.org/r/23793/diff/
Testing
-------
Yes.
Log:
@Desc: Test to List Security Groups pagination ... === TestName: test_01_list_securitygroups_pagination | Status : SUCCESS ===
ok
@Desc: Test to Authorize and Revoke Ingress for Security Group ... SKIP: skip
@Desc: Test to Authorize and Revoke Egress for Security Group ... SKIP: skip
----------------------------------------------------------------------
Ran 3 tests in 5.845s
OK (SKIP=2)
Thanks,
Ashutosh Kelkar
Re: Review Request 23793: CLOUDSTACK-7137: Resolving cleanup issue in
test_escalations_securitygroups.py
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23793/#review48386
-----------------------------------------------------------
Commit 8d8190ea4e00edb0f7ce9665535adcc7a5b5097d in cloudstack's branch refs/heads/4.4-forward from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=8d8190e ]
CLOUDSTACK-7137: Resolving cleanup issue in test_escalations_securitygroups.py
- ASF Subversion and Git Services
On July 22, 2014, 7:05 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23793/
> -----------------------------------------------------------
>
> (Updated July 22, 2014, 7:05 a.m.)
>
>
> Review request for cloudstack and Girish Shilamkar.
>
>
> Bugs: CLOUDSTACK-7137
> https://issues.apache.org/jira/browse/CLOUDSTACK-7137
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Resolved the cleanup issue. The security group was not removed from cleanup list after deleting it. So it failed to find the security group in cleanup operation.
>
> Also, removed the unnecessary imports.
>
>
> Diffs
> -----
>
> test/integration/component/test_escalations_securitygroups.py 8934088
>
> Diff: https://reviews.apache.org/r/23793/diff/
>
>
> Testing
> -------
>
> Yes.
> Log:
> @Desc: Test to List Security Groups pagination ... === TestName: test_01_list_securitygroups_pagination | Status : SUCCESS ===
> ok
> @Desc: Test to Authorize and Revoke Ingress for Security Group ... SKIP: skip
> @Desc: Test to Authorize and Revoke Egress for Security Group ... SKIP: skip
>
> ----------------------------------------------------------------------
> Ran 3 tests in 5.845s
>
> OK (SKIP=2)
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 23793: CLOUDSTACK-7137: Resolving cleanup issue in
test_escalations_securitygroups.py
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23793/#review48902
-----------------------------------------------------------
Commit 1ca9abd6dc8013dd1dc4e4f9ca1eabb71785cc37 in cloudstack's branch refs/heads/4.4 from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=1ca9abd ]
CLOUDSTACK-7137: Resolving cleanup issue in test_escalations_securitygroups.py
(cherry picked from commit 8d8190ea4e00edb0f7ce9665535adcc7a5b5097d)
- ASF Subversion and Git Services
On July 22, 2014, 7:05 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23793/
> -----------------------------------------------------------
>
> (Updated July 22, 2014, 7:05 a.m.)
>
>
> Review request for cloudstack and Girish Shilamkar.
>
>
> Bugs: CLOUDSTACK-7137
> https://issues.apache.org/jira/browse/CLOUDSTACK-7137
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Resolved the cleanup issue. The security group was not removed from cleanup list after deleting it. So it failed to find the security group in cleanup operation.
>
> Also, removed the unnecessary imports.
>
>
> Diffs
> -----
>
> test/integration/component/test_escalations_securitygroups.py 8934088
>
> Diff: https://reviews.apache.org/r/23793/diff/
>
>
> Testing
> -------
>
> Yes.
> Log:
> @Desc: Test to List Security Groups pagination ... === TestName: test_01_list_securitygroups_pagination | Status : SUCCESS ===
> ok
> @Desc: Test to Authorize and Revoke Ingress for Security Group ... SKIP: skip
> @Desc: Test to Authorize and Revoke Egress for Security Group ... SKIP: skip
>
> ----------------------------------------------------------------------
> Ran 3 tests in 5.845s
>
> OK (SKIP=2)
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>
Re: Review Request 23793: CLOUDSTACK-7137: Resolving cleanup issue in
test_escalations_securitygroups.py
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23793/#review48385
-----------------------------------------------------------
Commit 45888e214c949d1e48d800339b366c42a7990641 in cloudstack's branch refs/heads/master from Ashutosh K
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=45888e2 ]
CLOUDSTACK-7137: Resolving cleanup issue in test_escalations_securitygroups.py
- ASF Subversion and Git Services
On July 22, 2014, 7:05 a.m., Ashutosh Kelkar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23793/
> -----------------------------------------------------------
>
> (Updated July 22, 2014, 7:05 a.m.)
>
>
> Review request for cloudstack and Girish Shilamkar.
>
>
> Bugs: CLOUDSTACK-7137
> https://issues.apache.org/jira/browse/CLOUDSTACK-7137
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Resolved the cleanup issue. The security group was not removed from cleanup list after deleting it. So it failed to find the security group in cleanup operation.
>
> Also, removed the unnecessary imports.
>
>
> Diffs
> -----
>
> test/integration/component/test_escalations_securitygroups.py 8934088
>
> Diff: https://reviews.apache.org/r/23793/diff/
>
>
> Testing
> -------
>
> Yes.
> Log:
> @Desc: Test to List Security Groups pagination ... === TestName: test_01_list_securitygroups_pagination | Status : SUCCESS ===
> ok
> @Desc: Test to Authorize and Revoke Ingress for Security Group ... SKIP: skip
> @Desc: Test to Authorize and Revoke Egress for Security Group ... SKIP: skip
>
> ----------------------------------------------------------------------
> Ran 3 tests in 5.845s
>
> OK (SKIP=2)
>
>
> Thanks,
>
> Ashutosh Kelkar
>
>