You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bcel-dev@jakarta.apache.org by db...@apache.org on 2005/04/08 04:47:39 UTC

svn commit: r160508 - jakarta/bcel/trunk/src/java/org/apache/bcel/classfile/JavaClass.java

Author: dbrosius
Date: Thu Apr  7 19:47:39 2005
New Revision: 160508

URL: http://svn.apache.org/viewcvs?view=rev&rev=160508
Log:
Bug: 34318 JavaClass.dump only closes streams that it opens

Modified:
    jakarta/bcel/trunk/src/java/org/apache/bcel/classfile/JavaClass.java

Modified: jakarta/bcel/trunk/src/java/org/apache/bcel/classfile/JavaClass.java
URL: http://svn.apache.org/viewcvs/jakarta/bcel/trunk/src/java/org/apache/bcel/classfile/JavaClass.java?view=diff&r1=160507&r2=160508
==============================================================================
--- jakarta/bcel/trunk/src/java/org/apache/bcel/classfile/JavaClass.java (original)
+++ jakarta/bcel/trunk/src/java/org/apache/bcel/classfile/JavaClass.java Thu Apr  7 19:47:39 2005
@@ -258,7 +258,15 @@
         dir.mkdirs();
     }
 
-    dump(new DataOutputStream(new FileOutputStream(file)));
+    DataOutputStream dos = null;
+    try {
+    	dos = new DataOutputStream(new FileOutputStream(file));
+    	dump(dos);
+    }
+    finally {
+    	if (dos != null)
+    		dos.close();
+    }
   }
 
   /** 
@@ -338,8 +346,7 @@
         attributes[i].dump(file);
     } else
       file.writeShort(0);
-
-    file.close();
+    file.flush();
   }
 
   /**



---------------------------------------------------------------------
To unsubscribe, e-mail: bcel-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: bcel-dev-help@jakarta.apache.org