You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2017/11/16 00:47:36 UTC
Re: Review Request 63019: Encapsulated common error handling in CSI
clients.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63019/#review191132
-----------------------------------------------------------
src/csi/client.cpp
Lines 34-49 (patched)
<https://reviews.apache.org/r/63019/#comment268743>
Can you add a comment explaining why these are recoverable? And how to recover from them (or a TODO if that has yet to be implemented).
- Joseph Wu
On Oct. 16, 2017, 5:37 p.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63019/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2017, 5:37 p.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> By implementing the validation logic and error handling in
> `mesos::csi::Client`, the implementation of the storage local resource
> provider could be cleaner. In the furute, we could also implement the
> retry logic here.
>
>
> Diffs
> -----
>
> src/Makefile.am b60a54a031260de6f1fb43584ae5083df2dc7e31
> src/csi/client.cpp e171f030efedc60521053399055d67bf99d3fcd2
> src/tests/mock_csi_plugin.hpp b7926c4b4ca980e37131c3e9b227343e80f5c002
> src/tests/mock_csi_plugin.cpp 46ca398e48578537393e4050c3a9920b367b8946
>
>
> Diff: https://reviews.apache.org/r/63019/diff/3/
>
>
> Testing
> -------
>
> make test
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 63019: Encapsulated common error handling in CSI
clients.
Posted by Chun-Hung Hsiao <ch...@mesosphere.io>.
> On Nov. 16, 2017, 12:47 a.m., Joseph Wu wrote:
> > src/csi/client.cpp
> > Lines 34-49 (patched)
> > <https://reviews.apache.org/r/63019/diff/3/?file=1870951#file1870951line34>
> >
> > Can you add a comment explaining why these are recoverable? And how to recover from them (or a TODO if that has yet to be implemented).
These are the idempotent behaviors. There'll be some CSI spec changes in error handling in the next CSI bump, and the code here will be changed accordingly.
- Chun-Hung
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63019/#review191132
-----------------------------------------------------------
On Oct. 17, 2017, 12:37 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63019/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2017, 12:37 a.m.)
>
>
> Review request for mesos and Jie Yu.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> By implementing the validation logic and error handling in
> `mesos::csi::Client`, the implementation of the storage local resource
> provider could be cleaner. In the furute, we could also implement the
> retry logic here.
>
>
> Diffs
> -----
>
> src/Makefile.am b60a54a031260de6f1fb43584ae5083df2dc7e31
> src/csi/client.cpp e171f030efedc60521053399055d67bf99d3fcd2
> src/tests/mock_csi_plugin.hpp b7926c4b4ca980e37131c3e9b227343e80f5c002
> src/tests/mock_csi_plugin.cpp 46ca398e48578537393e4050c3a9920b367b8946
>
>
> Diff: https://reviews.apache.org/r/63019/diff/3/
>
>
> Testing
> -------
>
> make test
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>