[GitHub] [ignite-3] Pochatkin commented on a diff in pull request #2044: IGNITE-19384 Update deployment units after deploy

["Pochatkin (via GitHub)" <gi...@apache.org>]

Pochatkin commented on code in PR #2044:
URL: https://github.com/apache/ignite-3/pull/2044#discussion_r1195267778


##########
modules/code-deployment/src/test/java/org/apache/ignite/deployment/metastore/DeploymentUnitMetastoreImplTest.java:
##########
@@ -0,0 +1,168 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ *      http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.ignite.deployment.metastore;
+
+import static org.apache.ignite.internal.rest.api.deployment.DeploymentStatus.DEPLOYED;
+import static org.apache.ignite.internal.rest.api.deployment.DeploymentStatus.UPLOADING;
+import static org.apache.ignite.internal.testframework.matchers.CompletableFutureMatcher.willBe;
+import static org.hamcrest.MatcherAssert.assertThat;
+import static org.hamcrest.Matchers.containsInAnyOrder;
+import static org.hamcrest.Matchers.equalTo;
+
+import java.nio.file.Path;
+import java.util.Collections;
+import java.util.List;
+import org.apache.ignite.internal.deployunit.UnitMeta;
+import org.apache.ignite.internal.deployunit.UnitStatus;
+import org.apache.ignite.internal.deployunit.metastore.DeploymentUnitMetastoreImpl;
+import org.apache.ignite.internal.deployunit.version.Version;
+import org.apache.ignite.internal.metastorage.MetaStorageManager;
+import org.apache.ignite.internal.metastorage.impl.StandaloneMetaStorageManager;
+import org.apache.ignite.internal.metastorage.server.KeyValueStorage;
+import org.apache.ignite.internal.metastorage.server.persistence.RocksDbKeyValueStorage;
+import org.apache.ignite.internal.testframework.WorkDirectory;
+import org.apache.ignite.internal.testframework.WorkDirectoryExtension;
+import org.apache.ignite.internal.vault.VaultManager;
+import org.apache.ignite.internal.vault.inmemory.InMemoryVaultService;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.extension.ExtendWith;
+
+/**
+ * Test suite for {@link DeploymentUnitMetastoreImpl}.
+ */
+@ExtendWith(WorkDirectoryExtension.class)
+public class DeploymentUnitMetastoreImplTest {
+
+    private final VaultManager vaultManager = new VaultManager(new InMemoryVaultService());
+
+    private DeploymentUnitMetastoreImpl metastore;
+
+    @WorkDirectory
+    private Path workDir;
+
+    @BeforeEach
+    public void setup() {
+        KeyValueStorage storage = new RocksDbKeyValueStorage("test", workDir);
+
+        MetaStorageManager metaStorageManager = StandaloneMetaStorageManager.create(vaultManager, storage);
+
+        vaultManager.start();
+        metaStorageManager.start();
+
+        metastore = new DeploymentUnitMetastoreImpl(metaStorageManager);
+    }
+
+    @Test
+    public void clusterStatusTest() {
+        String id = "id1";
+        Version version = Version.parseVersion("1.1.1");
+
+        assertThat(metastore.createClusterStatus(id, version), willBe(true));
+
+        assertThat(metastore.getClusterStatus(id, version),
+                willBe(new UnitMeta(id, version, UPLOADING)));
+
+        assertThat(metastore.updateClusterStatus(id, version, DEPLOYED), willBe(true));
+        assertThat(metastore.getClusterStatus(id, version),
+                willBe(new UnitMeta(id, version, DEPLOYED)));
+
+        assertThat(metastore.remove(id, version), willBe(true));
+
+        assertThat(metastore.getClusterStatus(id, version), willBe((UnitMeta) null));
+    }
+
+    @Test
+    public void nodeStatusTest() {
+        String id = "id2";
+        Version version = Version.parseVersion("1.1.1");
+
+        String node1 = "node1";
+        String node2 = "node2";
+        String node3 = "node3";
+
+        assertThat(metastore.createClusterStatus(id, version), willBe(true));
+        assertThat(metastore.getClusterStatus(id, version),
+                willBe(new UnitMeta(id, version, UPLOADING)));
+
+        assertThat(metastore.createNodeStatus(id, version, node1), willBe(true));
+        assertThat(metastore.getNodeStatus(id, version, node1),
+                willBe(new UnitMeta(id, version, UPLOADING)));
+
+        assertThat(metastore.updateNodeStatus(id, version, node1, DEPLOYED), willBe(true));
+        assertThat(metastore.getNodeStatus(id, version, node1),
+                willBe(new UnitMeta(id, version, DEPLOYED)));
+
+        assertThat(metastore.createNodeStatus(id, version, node2), willBe(true));
+        assertThat(metastore.getNodeStatus(id, version, node2),
+                willBe(new UnitMeta(id, version, UPLOADING)));
+
+        assertThat(metastore.createNodeStatus(id, version, node3), willBe(true));
+
+        assertThat(metastore.updateClusterStatus(id, version, DEPLOYED), willBe(true));
+        assertThat(metastore.getClusterStatus(id, version),
+                willBe(new UnitMeta(id, version, DEPLOYED)));
+
+        assertThat(metastore.getClusterStatuses(id),
+                willBe(UnitStatus.builder(id).append(version, DEPLOYED).build())
+        );
+
+        assertThat(metastore.remove(id, version), willBe(true));
+        assertThat(metastore.getNodeStatus(id, version, node1),
+                willBe((UnitMeta) null));
+    }
+
+    @Test
+    public void findByNodeId() {
+        String id1 = "id3";
+        String id2 = "id4";
+        Version version = Version.parseVersion("1.1.1");
+
+        String node1 = "node1";
+        String node2 = "node2";
+        String node3 = "node3";
+
+        assertThat(metastore.createClusterStatus(id1, version), willBe(true));
+        assertThat(metastore.createNodeStatus(id1, version, node1), willBe(true));
+        assertThat(metastore.createNodeStatus(id1, version, node2), willBe(true));
+        assertThat(metastore.createNodeStatus(id1, version, node3), willBe(true));
+
+        assertThat(metastore.createClusterStatus(id2, version), willBe(true));
+        assertThat(metastore.updateClusterStatus(id2, version, DEPLOYED), willBe(true));
+        assertThat(metastore.getClusterStatus(id2, version), willBe(new UnitMeta(id2, version, DEPLOYED)));
+
+        assertThat(metastore.createNodeStatus(id2, version, node1), willBe(true));
+        assertThat(metastore.createNodeStatus(id2, version, node2), willBe(true));
+        assertThat(metastore.createNodeStatus(id2, version, node3), willBe(true));
+
+        assertThat(metastore.findAllByNodeConsistentId(node1), willBe(Collections.emptyList()));
+
+        assertThat(metastore.updateNodeStatus(id1, version, node1, DEPLOYED), willBe(true));
+        assertThat(metastore.findAllByNodeConsistentId(node1), willBe(equalTo(
+                List.of(UnitStatus.builder(id1).append(version, UPLOADING).build())

Review Comment:
   DEPLOY is node status. UPLOADING is cluster status



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org