[GitHub] [submarine] jiwq edited a comment on pull request #270: SUBMARINE-462. Submarine server should support helm charts installation

[GitBox <gi...@apache.org>]

jiwq edited a comment on pull request #270:
URL: https://github.com/apache/submarine/pull/270#issuecomment-634344776


   > > @JohnTing , I've discussed with the intention of multiple helm charts with Wanqiang. Only one big concern is that it seems we'd have to release multiple helms chars if we would like "helm install stable/submarine"?
   > 
   > No, after I update dependencies , I can merge 3 helm charts into one now.
   
   @JohnTing Thanks for your patience and careful work. If we decide merge charts, maybe we should keep only the `submarine` charts under `helm-charts` folder. Due to charts that use `file://` are not allowed in the official Helm repository, so if we want to release it to official repo, you should merge to one chart rather use the dependencies feature.
   
   By the way, the purpose of the split proposal is for easy maintenance and scale at later, also the submarine user can select which machine learning framework can be deployed within him/her cluster. And in the initial stage, I did not consider to release the charts to official repo.
   
   I suggest use the split proposal, but if we want to release it to official repo, I think the single chart is the best practice.
   
   cc: @tangzhankun @liuxunorg 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org