You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-commits@jackrabbit.apache.org by ch...@apache.org on 2017/07/10 04:17:13 UTC

svn commit: r1801407 - in /jackrabbit/oak/trunk: oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentCheckpointMBean.java oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/SegmentCheckpointMBean.java

Author: chetanm
Date: Mon Jul 10 04:17:13 2017
New Revision: 1801407

URL: http://svn.apache.org/viewvc?rev=1801407&view=rev
Log:
OAK-6436 - Log message on checkpoint MBean invocation

Modified:
    jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentCheckpointMBean.java
    jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/SegmentCheckpointMBean.java

Modified: jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentCheckpointMBean.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentCheckpointMBean.java?rev=1801407&r1=1801406&r2=1801407&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentCheckpointMBean.java (original)
+++ jackrabbit/oak/trunk/oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/document/DocumentCheckpointMBean.java Mon Jul 10 04:17:13 2017
@@ -27,6 +27,8 @@ import javax.management.openmbean.OpenDa
 import javax.management.openmbean.TabularDataSupport;
 
 import org.apache.jackrabbit.oak.commons.jmx.AbstractCheckpointMBean;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 import static org.apache.jackrabbit.oak.plugins.document.Checkpoints.Info;
 
@@ -34,6 +36,7 @@ import static org.apache.jackrabbit.oak.
  * {@code CheckpointMBean} implementation for the {@code DocumentNodeStore}.
  */
 public class DocumentCheckpointMBean extends AbstractCheckpointMBean {
+    private final Logger log = LoggerFactory.getLogger(getClass());
     private final DocumentNodeStore store;
 
     public DocumentCheckpointMBean(DocumentNodeStore store) {
@@ -68,11 +71,14 @@ public class DocumentCheckpointMBean ext
 
     @Override
     public String createCheckpoint(long lifetime) {
-        return store.checkpoint(lifetime);
+        String cp = store.checkpoint(lifetime);
+        log.info("Created checkpoint [{}] with lifetime {}", cp, lifetime);
+        return cp;
     }
 
     @Override
     public boolean releaseCheckpoint(String checkpoint) {
+        log.info("Released checkpoint [{}]", checkpoint);
         return store.release(checkpoint);
     }
 

Modified: jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/SegmentCheckpointMBean.java
URL: http://svn.apache.org/viewvc/jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/SegmentCheckpointMBean.java?rev=1801407&r1=1801406&r2=1801407&view=diff
==============================================================================
--- jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/SegmentCheckpointMBean.java (original)
+++ jackrabbit/oak/trunk/oak-segment-tar/src/main/java/org/apache/jackrabbit/oak/segment/SegmentCheckpointMBean.java Mon Jul 10 04:17:13 2017
@@ -29,11 +29,14 @@ import org.apache.jackrabbit.oak.api.Typ
 import org.apache.jackrabbit.oak.spi.state.ChildNodeEntry;
 import org.apache.jackrabbit.oak.spi.state.NodeState;
 import org.apache.jackrabbit.oak.commons.jmx.AbstractCheckpointMBean;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
 
 /**
  * {@code CheckpointMBean} implementation for the {@code SegmentNodeStore}.
  */
 public class SegmentCheckpointMBean extends AbstractCheckpointMBean {
+    private final Logger log = LoggerFactory.getLogger(getClass());
     private final SegmentNodeStore store;
 
     public SegmentCheckpointMBean(SegmentNodeStore store) {
@@ -75,11 +78,14 @@ public class SegmentCheckpointMBean exte
 
     @Override
     public String createCheckpoint(long lifetime) {
-        return store.checkpoint(lifetime);
+        String cp = store.checkpoint(lifetime);
+        log.info("Created checkpoint [{}] with lifetime {}", cp, lifetime);
+        return cp;
     }
 
     @Override
     public boolean releaseCheckpoint(String checkpoint) {
+        log.info("Released checkpoint [{}]", checkpoint);
         return store.release(checkpoint);
     }