You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "michael-s-molina (via GitHub)" <gi...@apache.org> on 2023/04/03 20:18:19 UTC
[GitHub] [superset] michael-s-molina opened a new pull request, #23567: fix: QueryParamProvider error on backend rendered views
michael-s-molina opened a new pull request, #23567:
URL: https://github.com/apache/superset/pull/23567
### SUMMARY
This PR fixes the following `QueryParamProvider` error on backend rendered views:
```
LocationProvider.js?e373:13 Uncaught Error: useQueryParams must be used within a QueryParamProvider
at useLocationContext (LocationProvider.js?e373:13:1)
at useQueryParams (useQueryParams.js?5bf2:71:1)
at RightMenuWithQueryWrapper (RightMenu.tsx?e833:571:1)
at renderWithHooks (react-dom.development.js?61bb:14804:1)
at mountIndeterminateComponent (react-dom.development.js?61bb:17483:1)
at beginWork (react-dom.development.js?61bb:18597:1)
at HTMLUnknownElement.callCallback (react-dom.development.js?61bb:189:1)
at Object.invokeGuardedCallbackDev (react-dom.development.js?61bb:238:1)
at invokeGuardedCallback (react-dom.development.js?61bb:293:1)
at beginWork$1 (react-dom.development.js?61bb:23204:1)
```
### TESTING INSTRUCTIONS
Make sure the error does not appear on backend rendered pages such as login, list of users, list of roles, etc.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #23567: fix: QueryParamProvider error on backend rendered views
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #23567:
URL: https://github.com/apache/superset/pull/23567#issuecomment-1494988508
## [Codecov](https://codecov.io/gh/apache/superset/pull/23567?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23567](https://codecov.io/gh/apache/superset/pull/23567?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (3c04bac) into [master](https://codecov.io/gh/apache/superset/commit/cdc7af11bf4d4ba8f98b059a3813ddcaaf55b46e?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cdc7af1) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 3c04bac differs from pull request most recent head 5d43f86. Consider uploading reports for the commit 5d43f86 to get more accurate results
```diff
@@ Coverage Diff @@
## master #23567 +/- ##
=======================================
Coverage 67.71% 67.71%
=======================================
Files 1914 1914
Lines 73994 73994
Branches 8033 8033
=======================================
Hits 50103 50103
Misses 21841 21841
Partials 2050 2050
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.93% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/23567?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/views/menu.tsx](https://codecov.io/gh/apache/superset/pull/23567?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL21lbnUudHN4) | `0.00% <ø> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina merged pull request #23567: fix: QueryParamProvider error on backend rendered views
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina merged PR #23567:
URL: https://github.com/apache/superset/pull/23567
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org