You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/03/25 04:14:46 UTC

[GitHub] [iceberg] uncleGen commented on a change in pull request #2380: Spark: Qualify destination location before check when snapshot

uncleGen commented on a change in pull request #2380:
URL: https://github.com/apache/iceberg/pull/2380#discussion_r601028952



##########
File path: spark3/src/main/java/org/apache/iceberg/actions/Spark3SnapshotAction.java
##########
@@ -135,10 +140,23 @@ protected TableCatalog checkSourceCatalog(CatalogPlugin catalog) {
 
   @Override
   public SnapshotAction withLocation(String location) {
-    Preconditions.checkArgument(!sourceTableLocation().equals(location),

Review comment:
       `sourceTableLocation` is converted from URI, while `location` comes from SQL command. We should qualify the `location` before check equals.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org