You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/20 13:46:02 UTC

[GitHub] [flink] zentol opened a new pull request, #20022: [FLINK-27933][coordination] OperationResult is serializable

zentol opened a new pull request, #20022:
URL: https://github.com/apache/flink/pull/20022

   Based on #19968 because this PR changes some timings that trigger FLINK-27972.
   
   With this PR the OperationResult is serializable, as well as the contained result.
   Additionally the switch to force serialization, introduced in FLINK-26780, now also applies to return values (and not just method arguments). Several problematic cases, mostly in tests, were also fixed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on pull request #20022: [FLINK-27933][coordination] OperationResult is serializable

Posted by GitBox <gi...@apache.org>.
zentol commented on PR #20022:
URL: https://github.com/apache/flink/pull/20022#issuecomment-1164303120

   I'll add a comment to the AkkaRpcActorOversizedResponseMessageTest.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #20022: [FLINK-27933][coordination] OperationResult is serializable

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #20022:
URL: https://github.com/apache/flink/pull/20022#issuecomment-1160473118

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "319bba41c0ead843eb41754b98731bdfd049b23f",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "319bba41c0ead843eb41754b98731bdfd049b23f",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * 319bba41c0ead843eb41754b98731bdfd049b23f UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on pull request #20022: [FLINK-27933][coordination] OperationResult is serializable

Posted by GitBox <gi...@apache.org>.
zentol commented on PR #20022:
URL: https://github.com/apache/flink/pull/20022#issuecomment-1164564569

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol commented on pull request #20022: [FLINK-27933][coordination] OperationResult is serializable

Posted by GitBox <gi...@apache.org>.
zentol commented on PR #20022:
URL: https://github.com/apache/flink/pull/20022#issuecomment-1164302299

   I documented the exceptions in the commit message:
   ```
   - allow tests to opt-out of serializability force
   - never force serialization in AkkaRpcActorOversizedResponseMessageTest, because it affected the payload size
   - DispatcherTest no longer relies on retrieving the same object instance via RPC
   - ResourceManager#requestTaskExecutorThreadInfoGateway is just not serializable; see FLINK-27954
   - ClassLoaderITCase wrongly assumed that serialization occurs
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] zentol merged pull request #20022: [FLINK-27933][coordination] OperationResult is serializable

Posted by GitBox <gi...@apache.org>.
zentol merged PR #20022:
URL: https://github.com/apache/flink/pull/20022


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org