You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@doris.apache.org by GitBox <gi...@apache.org> on 2019/03/12 01:01:27 UTC
[GitHub] [incubator-doris] chaoyli commented on a change in pull request
#729: Fix memory problem of reader
chaoyli commented on a change in pull request #729: Fix memory problem of reader
URL: https://github.com/apache/incubator-doris/pull/729#discussion_r264248590
##########
File path: be/src/olap/rowset/alpha_rowset_reader.cpp
##########
@@ -120,9 +180,9 @@ int64_t AlphaRowsetReader::get_filtered_rows() {
OLAPStatus AlphaRowsetReader::_get_next_block(size_t pos, RowBlock** row_block) {
// get next block
- ColumnData* column_data = _column_datas[pos].get();
- OLAPStatus status = column_data->get_next_block(row_block);
- if (status != OLAP_SUCCESS) {
+ ColumnData* column_data = _column_datas[pos].get();
Review comment:
no need to shared_ptr
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org